This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Update delivery-logs build 'result' #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Jun 23, 2016
richard-cox
commented
- show 'Success'/'Failed' for pipeline_completed
- link should only be seen for 'Success'
- link should take user to their app, not the build log
- removed now defunct function from controller
- updated tests
- show 'Success'/'Failed' for pipeline_completed - link should only be seen for 'Success' - link should take user to their app, not the build log - removed now defunct function from controller - updated tests
| appCtrl.model.application.summary.routes[0]" | ||
| target="_blank" | ||
| ng-init="route=appCtrl.model.application.summary.routes[0]" | ||
| ng-href="http://{{ route.host + '.' + route.domain.name + route.path }}">view</a> |
There was a problem hiding this comment.
Are we should the protocol is http? but not https?
There was a problem hiding this comment.
I've had a look through the Cloud Foundry API with Irfan and it looks like routes are agnostic of protocol (see https://apidocs.cloudfoundry.org/237/routes/creating_a_route.html). Nothing can be specified so think we should be already by defaulting to http.
Did look again at the route object though and fixed a few issues (added port, ensure path was preceded by forward slash).
| appCtrl.model.application.summary.routes[0]" | ||
| target="_blank" | ||
| ng-init="route=appCtrl.model.application.summary.routes[0]" | ||
| ng-href="http://{{ route.host + '.' + route.domain.name + (route.port ? ':' + route.port : '') + '/' + route.path }}">view</a> |
There was a problem hiding this comment.
I believe route.path will already have a slash pre-pended so you don't need to add it here
There was a problem hiding this comment.
Is that a restriction enforced by HCF, or they check and prepend? Was wondering if we ever get the state where we show an app created outside the console where there is no slash. Two slashes aren't valid but I think most browser will accept them. Either way, happy to remove if you wish?
There was a problem hiding this comment.
yeah, according to CF's API documentation, the path or route has to be start with slash. the api doc is at http://apidocs.cloudfoundry.org/237/routes/check_a_route_exists.html.
There was a problem hiding this comment.
Ahhh, ok. Slash removed in latest commit
richard-cox
added a commit
that referenced
this pull request
Oct 5, 2020
* WIP * Add theme migration * File moves * WIP * Add theme migration * Start to make core a separate library * Tweaks * WIP * Fix package imports * Fix migration script * First pass at permission effects * Fix merge issues * First pass at reducer * Tidy up logging * Fix dark theme support * Final set of cloud-foundry code out of common * TIdy up and get themable packages working * Tidy up custom build code * Tidy ups * Set defaults when no stratos.yaml file is present * FIx migrate script for when stratos.yaml not present * Remove comments * Disable scss linter from code climate * Rejig example extensions to be a package for v4 build * Renames, todos * Minor fixes * Fix frontend unit test * Fix removed e2e target * Fix unit tests * Tweaks * Finish todos * Fix transition from space summary to app summary page - an entity service for a space with no org was cached by guid - an entity service for a space requiring org used cached version - solution is to make cache id include schema key (determines with/without org) * Add comment, tidy up rootUpdatingKey * Fix issue where gitlab summary tab threw errors in console - fixes #4325 * Push combine of permission configs into checkers - overcomes some weird change of permission type * Fix issue where default add/remove setting in change role by username was incorrect - add/remove radio button default value governed by add/remove feature flags - when one is set to false the radio button should be disabled and the other selected * Fix store-test-helper * Update readme following move to Travis-ci.com * Ensure the correct key is used metacard favourite info (#4321) * Fix display of details in endpoint card in endpoint list (#4319) * Clean default/blocked logic * Rename @stratos to @stratosui * FIx references in tsconfig.json * Revert change to @stratosui in code * Revert change to @stratosui in code * Fix endpoint connect * Fix unit test * Fix e2e test * Change following review #1 * Bump github.com/gorilla/websocket from 1.4.1 to 1.4.2 in /src/jetstream (#4199) * Bump github.com/gorilla/websocket from 1.4.1 to 1.4.2 in /src/jetstream Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/gorilla/websocket/releases) - [Commits](gorilla/websocket@v1.4.1...v1.4.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Update go.sum Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <neil.macdougall@suse.com> * Fix errors in console log during setup screens * Helm: Change default image pull policy to Always * Add copy address and edit to endpoint list view * Use icon that is less confusing with refresh * Change following review #2 - Fix cf package module file name - Make CUSTOM_USER_PERMISSION_CHECKERS optional - Remove need to inject CUSTOM_USER_PERMISSION_CHECKERS in multiple cf modules * Add newline at end for codeclimate * Tidy up code and add some more comments * Fix for buildpack filename wrapping on card * Fix code climate issue * Fix compilation issues * Update endpoint-list.helpers.ts * Improve naming * Tidy up * Update .gitignore * Tidy up. Build tools in dist/tools * Change following review * Rename tools to devkit. Add schematics * More improvements and theme schematic added. * Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 in /src/jetstream (#4336) * Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 in /src/jetstream Bumps [gopkg.in/yaml.v2](https://github.com/go-yaml/yaml) from 2.2.8 to 2.3.0. - [Release notes](https://github.com/go-yaml/yaml/releases) - [Commits](go-yaml/yaml@v2.2.8...v2.3.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * CI bump Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <neil_macdougall@hotmail.com> * Remove unused import * Remove unused import * [Security] Bump websocket-extensions from 0.1.3 to 0.1.4 (#4356) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. **This update includes a security fix.** - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Hide deployment info card if not space developer - fixes #4322 * Only space developers can create/unmap/delete routes in app routes table - fixes #4324 * Only Space Developers should be able to change count, terminate or ssh to instances - fixes #4330 * Permissions: Only Space Developers should be able to create/edit/delete an Autoscaler policy - fixes #4323 * Users with no developer roles could click on add app button - fixes #4361 * Fix tests * Fail CI build if imagelist generation fails * Org Managers: Disable org role checkboxes in roles stepper if not admin/org manager - fixes #4332 * Routes List: Filter by org breaks when user is an org auditor - fixes #4343 * Rename the e2e cf helper file * Fix autoscaler tab * Changes following review * A few minor tidy-ups to help with review * Fix several space developer permission bugs (#4362) * Hide deployment info card if not space developer - fixes #4322 * Only space developers can create/unmap/delete routes in app routes table - fixes #4324 * Only Space Developers should be able to change count, terminate or ssh to instances - fixes #4330 * Permissions: Only Space Developers should be able to create/edit/delete an Autoscaler policy - fixes #4323 * Users with no developer roles could click on add app button - fixes #4361 * Fix tests * Fix autoscaler tab * Changes following review * Fix service stepper navigation (#4366) * Fix service stepper navigation on create/edit cancel/sumbit - create service stepper from app service tab, marketplace service summary, service wall - edit service stepper from marketplace service instances, service wall instances, space service instances and app service instances lists - fixes #4052, contrinbutes to #4079, #4051 * Fix subscription leak - fixes #4295 - code no-longer needed * Force return location of service stepper, fix table edit of upsi and other improvements * Fix unit tests * Fix e2e tests * Fix e2e tests, add search to marketplace service instances table * Changes following review * Move base-entity-* to store package * Add snackbar * Remove pathget * Remove more store -> core dependencies * Move extension-types to store * Move favourite mgr and helper from core to store * Move user fav manager and helper to store package * More references * Fix logger service removal * Fix build * Address PR feedback * Fix LoggerService after code moves * Fix logger service ref * Fix build issues * Fix health check import * Move sortStringify (only used once) * NonOptionalKeys - only used once * Move KnownKeys * Move BrowserStandardEncoder * Remove last environment link * Move favourite config mapper * Remove dependency on StratosScopeStrings * Move BaseEndpointAuth * Move StratosTheme * Move ThemeService * Move types from utils.service that are only used once in store * Move PermissionValues * Move http and jetstream helpers * Move StyleService * Move MetricQueryType * Move getFullEndpointApiUrl * Move StratosStatus * Move generateStratosEntities back to core * Finish store -> core sep * Address PR feedback * Fix compilation issue * Fix merge weirdness * Merge downstream (#4369) * src based changes * changes to ./build * ./docs * ./ * Changes following review * Address PR feedback * fix build * whitespace changes * Fix in core public-api after merge * Fix duplicated k8s docs * Typed access to actions and entities via catalog entity: Core Stratos Entities (#4387) * WIP * WIP * WIP * Endpoint changes * Fix failure handling during connect on stepper * Fix favourites * Removed some TODOs * Fixes & todos * Unit test fixes * Fixes following merge * Fix cf unit tests * Changes following review * Theming improvements for header * Tweaks, Migration Script Docs & Notes on others (#4389) Co-authored-by: Neil MacDougall <neil.macdougall@suse.com> * Build devkit outside of dist folder * Add dist-devkit to git ignore * Ignore example packages when there's a stratos config file (#4399) * Fix CF App Restage (#4393) * Remove action entityLocation (not used) * Fix restage - fixes #4392 * Remove RequestEntityLocation * Update icons (#4404) * Update icons * Update docker icon and optimize other pngs * Improve resolution of container icon * Update e2e test for new icons * Improve theming to reduce need to override in a hacky way (#4407) * Change following merge Co-authored-by: Neil MacDougall <neil.macdougall@suse.com> Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <neil_macdougall@hotmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.