Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Fixing eslint issues. #411

Merged
merged 1 commit into from
Jun 27, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/app/api/serviceInstance/serviceInstance.api.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,9 @@
};
var removalData = {cnsi_guid: guid};
var data = this.$httpParamSerializer(removalData);
/* eslint-disable */
// TODO(woodnt): This should likely be a delete. We should investigate the Portal-proxy urls and verbs. https://jira.hpcloud.net/browse/TEAMFOUR-620
/* eslint-enable */
return this.$http.post('/pp/v1/unregister', data, config);
},

Expand Down
2 changes: 2 additions & 0 deletions src/app/api/serviceInstance/user/userServiceInstance.api.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,9 @@
};
var disconnectData = {cnsi_guid: guid};
var data = this.$httpParamSerializer(disconnectData);
/* eslint-disable */
// TODO(woodnt): This should likely be a delete. We should investigate the Portal-proxy urls and verbs. https://jira.hpcloud.net/browse/TEAMFOUR-620
/* eslint-enable */
return this.$http.post('/pp/v1/auth/logout/cnsi', data, config);
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@
this.warningMsg = gettext('Authentication failed, please try reconnect.');
this.detailView = detailView;
this.currentEndpoints = [];
/* eslint-disable */
// TODO(woodnt): There must be a more reproducable/general way of doing this. https://jira.hpcloud.net/browse/TEAMFOUR-626
/* eslint-enable */
this.cfModel = modelManager.retrieve('cloud-foundry.model.application');

$scope.$watchCollection(function () {
Expand Down
28 changes: 14 additions & 14 deletions src/plugins/cloud-foundry/model/auth/checkers/application-access.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@
}

/**
* @name: ApplicationAccessFactory
* @description: Function to return an ApplicationAccess class
* @name ApplicationAccessFactory
* @description Function to return an ApplicationAccess class
* @param {app.api.modelManager} modelManager - the Model management service
* @returns {ApplicationAccess}
*/
function ApplicationAccessFactory(modelManager) {
/**
* @name: ApplicationAccess
* @description: Constructor for ApplicationAccess
* @name ApplicationAccess
* @description Constructor for ApplicationAccess
* @param {Principal} principal Principal instance
* @param {Array} flags feature flags
* @constructor
Expand All @@ -42,8 +42,8 @@

angular.extend(ApplicationAccess.prototype, {
/**
* @name: create
* @description: Does user have create application permission in the space
* @name create
* @description Does user have create application permission in the space
* @param {Object} space Domain space
* @returns {boolean}
*/
Expand All @@ -58,8 +58,8 @@
},

/**
* @name: update
* @description: Does user have update application permission
* @name update
* @description Does user have update application permission
* @param {Object} app Application detail
* @returns {boolean}
*/
Expand All @@ -74,19 +74,19 @@
},

/**
* @name: delete
* @description: Does user have delete application permission
* @param {Object} app Application detail
* @name delete
* @description Does user have delete application permission
* @param {Object} app - Application detail
* @returns {boolean}
*/
delete: function(app) {
return this.baseAccess.delete(app);
},

/**
* @name: canHandle
* @description: Specifies that this ACL checker can handle `application` permission
* @param {String} resource
* @name canHandle
* @description Specifies that this ACL checker can handle `application` permission
* @param {String} resource - String representing the resource
* @returns {boolean}
*/
canHandle: function(resource) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@
}

/**
* @name: OrganizationAccessFactory
* @description: Function to return an OrganizationAccess class
* @param {app.api.modelManager} modelManager - the Model management service
* @name OrganizationAccessFactory
* @description Function to return an OrganizationAccess class
* @param {app.api.modelManager} modelManager - the Model management service
* @returns {OrganizationAccess}
*/
function OrganizationAccessFactory(modelManager) {
/**
* @name: OrganizationAccess
* @description: Constructor for OrganizationAccess
* @name OrganizationAccess
* @description Constructor for OrganizationAccess
* @param {Principal} principal Principal instance
* @param {Array} flags feature flags
* @constructor
Expand All @@ -43,29 +43,29 @@
angular.extend(OrganizationAccess.prototype, {

/**
* @name: create
* @description: Does user have create organization permission in the space
* @param {Object} space Domain space
* @name create
* @description Does user have create organization permission in the space
* @param {Object} space - Domain space
* @returns {boolean}
*/
create: function(space) {
return this.principal.isAdmin(space);
},

/**
* @name: update
* @description: Does user have update organization permission
* @name update
* @description Does user have update organization permission
* @returns {boolean}
*/
delete: function() {
return this.principal.isAdmin();
},

/**
* @name: delete
* @description: Does user have delete organization permission
* @name delete
* @description Does user have delete organization permission
* Original source contained a `//TODO(irfran):` annotation https://jira.hpcloud.net/browse/TEAMFOUR-625
* @param {Object} app Application detail
* @param {Object} org - Application detail
* @returns {boolean}
*/

Expand All @@ -80,9 +80,9 @@
},

/**
* @name: canHandle
* @description: Specifies that this ACL checker can handle `application` permission
* @param {String} resource
* @name canHandle
* @description Specifies that this ACL checker can handle `application` permission
* @param {String} resource - string specifying resource
* @returns {boolean}
*/
canHandle: function(resource) {
Expand Down
26 changes: 13 additions & 13 deletions src/plugins/cloud-foundry/model/auth/checkers/route-access.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@
}

/**
* @name: RouteAccessFactory
* @description: Function to return an RouteAccess class
* @name RouteAccessFactory
* @description Function to return an RouteAccess class
* @param {app.api.modelManager} modelManager - the Model management service
* @returns {RouteAccess}
*/
function RouteAccessFactory(modelManager) {
/**
* @name: RouteAccess
* @description: Constructor for RouteAccess
* @name RouteAccess
* @description Constructor for RouteAccess
* @param {Principal} principal Principal instance
* @param {Array} flags feature flags
* @constructor
Expand All @@ -42,8 +42,8 @@

angular.extend(RouteAccess.prototype, {
/**
* @name: create
* @description: Does user have create route permission in the space
* @name create
* @description Does user have create route permission in the space
* @param {Object} space Domain space
* @returns {boolean}
*/
Expand All @@ -69,8 +69,8 @@
},

/**
* @name: update
* @description: Does user have update route permission
* @name update
* @description Does user have update route permission
* @param {Object} route route detail
* @returns {boolean}
*/
Expand All @@ -96,8 +96,8 @@
},

/**
* @name: delete
* @description: Does user have delete route permission
* @name delete
* @description Does user have delete route permission
* @param {Object} route route detail
* @returns {boolean}
*/
Expand All @@ -119,9 +119,9 @@
},

/**
* @name: canHandle
* @description: Specifies that this ACL checker can handle `route` permission
* @param {String} resource
* @name canHandle
* @description Specifies that this ACL checker can handle `route` permission
* @param {String} resource - string representing the resource
* @returns {boolean}
*/
canHandle: function(resource) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,16 @@
}

/**
* @name: ServiceInstanceAccessFactory
* @description: Function to get a ServiceInstanceAccess class
* @name ServiceInstanceAccessFactory
* @description Function to get a ServiceInstanceAccess class
* @param {app.api.modelManager} modelManager - the Model management service
* @returns {ServiceInstanceAccess}
* @constructor
*/
function ServiceInstanceAccessFactory(modelManager) {
/**
* @name: ServiceInstanceAccess
* @description: Constructor for ServiceInstanceAccess
* @name ServiceInstanceAccess
* @description Constructor for ServiceInstanceAccess
* @param {Principal} principal Principal instance
* @param {Array} flags feature flags
* @constructor
Expand All @@ -43,8 +43,8 @@

angular.extend(ServiceInstanceAccess.prototype, {
/**
* @name: create
* @description: Does user have create service instance permission in the space
* @name create
* @description Does user have create service instance permission in the space
* @param {Object} space Domain space
* @returns {boolean}
*/
Expand All @@ -61,8 +61,8 @@
},

/**
* @name: update
* @description: Does user have update service instance permission
* @name update
* @description Does user have update service instance permission
* @param {Object} serviceInstance service instance detail
* @returns {boolean}
*/
Expand All @@ -78,8 +78,8 @@
},

/**
* @name: delete
* @description: Does user have delete application permission
* @name delete
* @description Does user have delete application permission
* @param {Object} serviceInstance service instance detail
* @returns {boolean}
*/
Expand All @@ -88,9 +88,9 @@
},

/**
* @name: canHandle
* @description: Specifies that this ACL checker can handle `managed_service_instance` permission
* @param {String} resource
* @name canHandle
* @description Specifies that this ACL checker can handle `managed_service_instance` permission
* @param {String} resource - string representing the resource
* @returns {boolean}
*/
canHandle: function(resource) {
Expand Down
Loading