Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Scalability: Improve scaling of users and organisations #4156

Merged
merged 14 commits into from
Mar 17, 2020
Merged

Scalability: Improve scaling of users and organisations #4156

merged 14 commits into from
Mar 17, 2020

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Mar 10, 2020 •
edited
Loading

Scaling Related Fixes

  • Fix double fetching of missing user relations for getUser (speeds up all pages that require a specific user's roles)
    • getUser would first attempt to fetch all users via getUsers
    • getUsers could take a long time due to missing relations (users with more than 50 per role)
    • getUser wouldn't wait for this to finish and then try and make an individual request to fetch user
    • this user would then also be validated and missing relations fetched
  • Remove org-space-route relation from orgs and org api requests (speeds up cf orgs list, org pages and all below)
  • Ensure we don't fetch entity counts unless we need to

General Fixes

@richard-cox
Fix delete org when org contains spaces
b7dcdf5
@richard-cox
Fix scaling related test scripts
b3e03f8
@richard-cox
Fix double fetching of missing user relations for getUser
5e23ea7 
- getUser would first attempt to fetch all users via getUsers
- getUsers could take a long time due to missing relations (users with more than 50 per role)
- getUser wouldn't wait for this to finish and then try and make an individual request to fetch user
- this user would then also be validated and missing relations fetched
@richard-cox richard-cox added in progress community Community Raised Issue labels Mar 10, 2020
@richard-cox richard-cox self-assigned this Mar 10, 2020
@richard-cox
Fix create many services script
4d60312
@richard-cox
Scaling improvements
7088585 
- Remove org-space-route relation from orgs and org api requests
- Ensure we don't fetch entity counts unless we need to
@richard-cox
Fix handling of generic errors to cf endpoints
1ca5dd4 
- sometimes errorResponse can be null (for instance timeout)
@richard-cox
Fix SI Delete
57f1dff 
- Delete SI success handler was incorrectly clearing pagination instead of just removing entity from pagination
@richard-cox
Fix UPSI Delete
c62fa1e 
- Delete of entity was fine, however it was not removed from list
- With bug entity was still not visible in list afterwards only due to nulls filtered out in list
@richard-cox richard-cox changed the title Scaling Related & Delete Org Fixes Scaling Related & Minor Fixes Mar 11, 2020
@richard-cox richard-cox added the conflicts Merge conflicts on PR label Mar 13, 2020
@richard-cox richard-cox added the needs attention This PR needs attention label Mar 13, 2020
@richard-cox richard-cox mentioned this pull request Mar 13, 2020
Merged
@richard-cox richard-cox removed conflicts Merge conflicts on PR needs attention This PR needs attention labels Mar 13, 2020
@richard-cox richard-cox mentioned this pull request Mar 13, 2020
Merged
nwmac
nwmac approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 861b9d6 into master Mar 17, 2020
@nwmac nwmac deleted the scale-related-fixes branch March 17, 2020 10:53
@richard-cox richard-cox added this to the 3.1.0 milestone Apr 14, 2020
@richard-cox richard-cox changed the title Scaling Related & Minor Fixes Scalability: Improve scaling of users and organisations Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
community Community Raised Issue ready for review
Projects
None yet
Milestone
3.1.0
2 participants
@richard-cox @nwmac