Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Only show metrics details on endpoint card/list when connected #4282

Merged
merged 1 commit into from
May 13, 2020
Merged

Only show metrics details on endpoint card/list when connected #4282

merged 1 commit into from
May 13, 2020

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented May 12, 2020

Fixes #4261

@nwmac nwmac self-assigned this May 12, 2020
richard-cox
richard-cox reviewed May 13, 2020
View reviewed changes
Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small bug, after disconnecting the endpoint the details are still shown. Navigating away and returning correctly hides details section. This is an improvement on what's there, can merge and create an issue?

@richard-cox richard-cox mentioned this pull request May 13, 2020
Open
@richard-cox richard-cox merged commit 2be2a2a into master May 13, 2020
@richard-cox richard-cox deleted the metrics-details-fix branch May 13, 2020 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richard-cox richard-cox richard-cox left review comments

Assignees

@nwmac nwmac

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deployment time does not show correctly in diagnostics when deployed with Helm 3
2 participants
@nwmac @richard-cox