This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Make permissions model extension friendly #4314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- overcomes some weird change of permission type
… into filemoves-permissions
richard-cox
added
ready for review
and removed
do not merge
nwmac
approved these changes
Jun 4, 2020
richard-cox
commented
Jun 4, 2020
src/frontend/packages/core/src/core/permissions/current-user-permissions.service.ts
Outdated
Show resolved
Hide resolved
src/frontend/packages/core/src/core/permissions/current-user-permissions.service.ts
Outdated
Show resolved
Hide resolved
src/frontend/packages/cloud-foundry/src/store/effects/roles.effects.ts
Outdated
Show resolved
Hide resolved
src/frontend/packages/cloud-foundry/src/store/selectors/cloud-foundry.selector.ts
Outdated
Show resolved
Hide resolved
src/frontend/packages/cloud-foundry/src/user-permissions/cf-user-permissions-checkers.ts
Outdated
Show resolved
Hide resolved
src/frontend/packages/core/src/core/permissions/stratos-user-permissions.checker.ts
Outdated
Show resolved
Hide resolved
...rontend/packages/store/src/reducers/current-user-roles-reducer/current-user-roles.reducer.ts
Outdated
Show resolved
Hide resolved
src/frontend/packages/store/src/types/current-user-roles.types.ts
Outdated
Show resolved
Hide resolved
- Fix cf package module file name - Make CUSTOM_USER_PERMISSION_CHECKERS optional - Remove need to inject CUSTOM_USER_PERMISSION_CHECKERS in multiple cf modules
richard-cox
force-pushed
the
filemoves-permissions
branch
from
245a18e
to
4d21e5a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Issue
Contention Point
Issues either fixed entirely by PR or finishing off work from other PRs