This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Fetch service in service instances card via store rather than inline #4417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Jul 2, 2020
richard-cox
commented
- fixes Visiting marketplace tab breaks service list #4397
- accessing entity via this.serviceInstanceEntity.entity.service_plan.entity.service.entity.service_broker_guid can sometimes fail
- fetch service, and thus service broker guid, from store instead
- this matches the table way of getting the broker
- fixes #4397 - accessing entity via this.serviceInstanceEntity.entity.service_plan.entity.service.entity.service_broker_guid can sometimes fail - fetch service, and thus service broker guid, from store instead - this matches the table way of getting the broker
This was referenced Jul 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #4417 +/- ##
==========================================
- Coverage 56.53% 56.23% -0.30%
==========================================
Files 886 891 +5
Lines 28915 29156 +241
Branches 4198 4219 +21
==========================================
+ Hits 16347 16396 +49
- Misses 12568 12760 +192 |
- ensure async properties have async pipe in html - bind to params rather than properties
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.