WIP: Extract the uaa package to an external library

[joefitzgerald]

Co-Authored-By: Caleb Washburn cwashburn@pivotal.io

[cfdreddbot]

Hey joefitzgerald!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/158203410

The labels on this github issue will be updated when the story is started.

[DennisDenuto]

@joefitzgerald This PR looks great! nice work! We have some concerns about the changes made to listing groups, client and users.

[DennisDenuto]

It looks like we have removed the ability to paginate the client/ groups / users endpoint. While I think this is convenient, we have concerns about performance as we know of some customers that have ~300,000 users.

We think that a nice compromise would be to keep this logic, however perhaps add the ability to 'opt-in' to listing all the users/groups/clients. (Perhaps a flag named --all). However, if this flag is not provided, then fallback to using pagination. Can we also add back startIndex and count?

[DennisDenuto]

As per our previous comment, can we please add back pagination?

[joefitzgerald]

Hey @DennisDenuto sure thing. This PR is based on v0.0.6 of the go-uaa dependency.

In v0.0.7 and v0.0.8 we add back functions that allow for listing a single page and listing all pages: https://github.com/cloudfoundry-community/go-uaa/releases

I can update the PR to make use of the latest release, but note thy the changeset will be significantly larger due to the breaking changes introduced in v0.0.7 and v0.0.8. Alternatively we could address that in a subsequent PR? What is your preference?

[DennisDenuto]

@joefitzgerald Thanks for sharing that context. in that case I think it makes sense to merge with v0.0.6 swiftly followed by an upgrade to v0.0.8. The lack of pagination in between should not affect anyone since we have not yet released uaa-cli.

[drnic]

After merging, I am getting failing test cases and my local files are being modified when running make && make install.

$ make && make install
...
Summarizing 4 Failures:

[Fail] ListUsers [It] understands the --zone flag
/Users/drnic/Projects/gopath/src/github.com/cloudfoundry-incubator/uaa-cli/vendor/github.com/onsi/gomega/ghttp/handlers.go:45

[Fail] ListGroups [It] understands the --zone flag
/Users/drnic/Projects/gopath/src/github.com/cloudfoundry-incubator/uaa-cli/vendor/github.com/onsi/gomega/ghttp/handlers.go:45

[Fail] ListUsers [It] executes SCIM queries based on flags
/Users/drnic/Projects/gopath/src/github.com/cloudfoundry-incubator/uaa-cli/vendor/github.com/onsi/gomega/ghttp/handlers.go:45

[Fail] ListGroups [It] executes SCIM queries based on flags
/Users/drnic/Projects/gopath/src/github.com/cloudfoundry-incubator/uaa-cli/vendor/github.com/onsi/gomega/ghttp/handlers.go:45

Ran 188 of 188 Specs in 6.365 seconds
FAIL! -- 184 Passed | 4 Failed | 0 Pending | 0 Skipped --- FAIL: TestCmd (6.37s)
FAIL

$ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   Gopkg.lock
	modified:   cmd/add_member.go
	modified:   cmd/create_user.go
	modified:   cmd/deactivate_user.go
	modified:   cmd/errors.go
	modified:   cmd/get_password_token.go
	modified:   cmd/get_user.go
	modified:   cmd/refresh_token.go
	modified:   cmd/root.go
	modified:   cmd/set_client_secret.go
	modified:   cmd/target.go

[drnic]

Perhaps can we cut releases of the old stable code before we resume merging + working on this repo again after a long break?