make && make install failing

[drnic]

After merging #6 , I am getting failing test cases and my local files are being modified when running make && make install.

$ make && make install
...
Summarizing 4 Failures:

[Fail] ListUsers [It] understands the --zone flag
/Users/drnic/Projects/gopath/src/github.com/cloudfoundry-incubator/uaa-cli/vendor/github.com/onsi/gomega/ghttp/handlers.go:45

[Fail] ListGroups [It] understands the --zone flag
/Users/drnic/Projects/gopath/src/github.com/cloudfoundry-incubator/uaa-cli/vendor/github.com/onsi/gomega/ghttp/handlers.go:45

[Fail] ListUsers [It] executes SCIM queries based on flags
/Users/drnic/Projects/gopath/src/github.com/cloudfoundry-incubator/uaa-cli/vendor/github.com/onsi/gomega/ghttp/handlers.go:45

[Fail] ListGroups [It] executes SCIM queries based on flags
/Users/drnic/Projects/gopath/src/github.com/cloudfoundry-incubator/uaa-cli/vendor/github.com/onsi/gomega/ghttp/handlers.go:45

Ran 188 of 188 Specs in 6.365 seconds
FAIL! -- 184 Passed | 4 Failed | 0 Pending | 0 Skipped --- FAIL: TestCmd (6.37s)
FAIL

$ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   Gopkg.lock
	modified:   cmd/add_member.go
	modified:   cmd/create_user.go
	modified:   cmd/deactivate_user.go
	modified:   cmd/errors.go
	modified:   cmd/get_password_token.go
	modified:   cmd/get_user.go
	modified:   cmd/refresh_token.go
	modified:   cmd/root.go
	modified:   cmd/set_client_secret.go
	modified:   cmd/target.go

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/158682397

The labels on this github issue will be updated when the story is started.

[DennisDenuto]

Hi @drnic
Hmm I am unable to reproduce:

make && make install
go get github.com/onsi/ginkgo/ginkgo
go get github.com/onsi/gomega
go get -u github.com/golang/dep/cmd/dep
go install github.com/golang/dep/cmd/dep
dep ensure
gofmt -l -s -w `find . -type f -name '*.go' -not -path "./vendor/*"`
./cmd/create_user.go
./cmd/refresh_token.go
./cmd/get_password_token.go
./cmd/target.go
./cmd/get_user.go
./cmd/add_member.go
./cmd/deactivate_user.go
./cmd/set_client_secret.go
./cmd/root.go
./cmd/errors.go
bin/test 2>&1
+ ginkgo -r -randomizeSuites -randomizeAllSpecs -race
[1530169456] Config Suite - 4/4 specs •••• SUCCESS! 5.340625ms PASS
[1530169456] Cli Suite - 19/19 specs ••••••••••••••••••• SUCCESS! 78.285217ms PASS
[1530169456] Utils Suite - 13/13 specs ••••••••••••• SUCCESS! 1.187068ms PASS
[1530169456] Cmd Suite - 188/188 specs •••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••• SUCCESS! 6.018101041s PASS

Can you confirm you ran the steps from the README:

go get code.cloudfoundry.org/uaa-cli
cd $GOPATH/src/code.cloudfoundry.org/uaa-cli
make && make install

I think your path might be an issue: /Users/drnic/Projects/gopath/src/github.com/cloudfoundry-incubator -> /Users/drnic/Projects/gopath/src/code.cloudfoundry.org

[drnic]

Thanks, yes I was using the github path. Working now.

Lol, perhaps we need a test to assert that the code is in the correct path :)

[drnic]

BTW, the make && make install still modified my local files:

	modified:   Gopkg.lock
	modified:   cmd/add_member.go
	modified:   cmd/create_user.go
	modified:   cmd/deactivate_user.go
	modified:   cmd/errors.go
	modified:   cmd/get_password_token.go
	modified:   cmd/get_user.go
	modified:   cmd/refresh_token.go
	modified:   cmd/root.go
	modified:   cmd/set_client_secret.go
	modified:   cmd/target.go