-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PKCE] allowpublic client option for grant_type authorization_code using PKCE with S256 method #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Info: allowpublic is an optional flag similar to autoapprove to define behaviour in oauth2 flow. The option allow to omit client_secret parameter and/or client authentication in grant_type authorization_code. Escpecially mobile scenarios showed the need for such option, because other OpenID providers allow in meanwhile similar use cases.
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/182174943 The labels on this github issue will be updated when the story is started. |
allowpublic = true means, client_secret can be omitted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info: allowpublic is an optional flag similar to autoapprove to define behaviour in oauth2 flow.
The option allow to omit client_secret parameter and/or client authentication in grant_type authorization_code.
Escpecially mobile scenarios showed the need for such option, because other OpenID providers allow in meanwhile similar
use cases.
The needed configuration for the clients can be passed via
Clients with allowpublic = true can omit client authentication completly (authorization or client_secret) but the PKCE flow with code_challange_method=S256 is need in the authorization_code flow