RateLimit Change: Use nanoTime time instead of currentTimeMillis #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/183853023 The labels on this github issue will be updated when the story is started. |
swalchemist
reviewed
Nov 22, 2022
.../cloudfoundry/identity/uaa/ratelimiting/internal/limitertracking/LimiterManagerImplTest.java
Outdated
Show resolved
Hide resolved
...a/org/cloudfoundry/identity/uaa/ratelimiting/internal/limitertracking/ExpirationBuckets.java
Outdated
Show resolved
Hide resolved
swalchemist
approved these changes
Nov 22, 2022
strehle
added a commit
that referenced
this pull request
Mar 3, 2023
Use nano time for IT Why: see infinite loops in tests and these might be resulted because of the VM and behaviour of this timeout check if vm goes into a suspend mode (only for a short time) and awakes then the time comparison can be a problem and this could explain the infinite loop. Saw similar things in #2105
Merged
strehle
added a commit
that referenced
this pull request
Mar 3, 2023
Use nano time for IT Why: see infinite loops in tests and these might be resulted because of the VM and behaviour of this timeout check if vm goes into a suspend mode (only for a short time) and awakes then the time comparison can be a problem and this could explain the infinite loop. Saw similar things in #2105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Change: System::currentTimeMillis moved to System::nanoTime
Others are mostly rename to make it transparant that we use internally nano time.
In stackoverflow and others I have read, that currentTimeMillis has issues in cases we have, means, if a process goes into sleep mode and awaks.