Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SAML config: convert SamlConfig toLower #2158

Merged
merged 5 commits into from
Jan 20, 2023
Merged

Fix SAML config: convert SamlConfig toLower #2158

merged 5 commits into from
Jan 20, 2023

Conversation

strehle
Copy link
Member

@strehle strehle commented Jan 10, 2023

Configuration from https://uaa.uaa-acceptance-k8s.cf-app.com uses UPPER Case Key ID
This causes an exception and non usable UAA for SAML.
Since it must have worked before this fix here should fix a regression

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/184190644

The labels on this github issue will be updated when the story is started.

@strehle strehle linked an issue Jan 10, 2023 that may be closed by this pull request
@strehle strehle requested review from a team January 10, 2023 08:49
Copy link
Contributor

@hsinn0 hsinn0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure that

@strehle strehle requested a review from hsinn0 January 19, 2023 14:26
@strehle strehle merged commit ffaf945 into develop Jan 20, 2023
@strehle strehle deleted the fix/2157 branch January 20, 2023 21:34
@cf-gitbot cf-gitbot added delivered accepted Accepted the issue and removed delivered labels Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Accepted the issue
Projects
Development

Successfully merging this pull request may close these issues.

Store saml key toLower to meet JKS requirements
3 participants