Fix: Fixing performance while calling containsAll over list

[saurabh-rahate]

Improving performance in case of

list.containsAll(anotherList)

by using HashSet wrapper around one of the lists

new HashSet<>(list).containsAll(anotherList)

This improves time complexity.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: saurabh-rahate / name: Saurabh Rahate (67c83d2)

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/184880763

The labels on this github issue will be updated when the story is started.

[strehle]

ok for me

[strehle]

@Tallicia @bruce-ricard any concerns

[Tallicia]

The 8 test look good and the optimization does as well.

[Tallicia]

Nice improvement.

[Tallicia]

Would be nice to see performance tests to see if sets are of large enough size in practice to know the real world performance improvement.

[bruce-ricard]

Thank you for making performance improvements.

To be perfectly frank, I am not convinced that this change will improve performance in the general practical world. I don't know if most objects don't have one or two roles. And this change forces the creation of 2 new hashsets every single time.

Also, we cannot find any usage of that equals method in the UAA code base. I don't think that this change will have any impact at all.

Additionally, I am not convinced that Java doesn't already use HashSets internally to resolve containsAll calls on List object.

@Tallicia and me

[strehle]

I have tested this and created an extra PR #2294
With a test of role about 10000 the difference is 300 ms compared to 30 ms , in case of more e.g. 100000xxx it sometimes runs into many seconds, so that I decided to stay only with 10000
So it brings the expected result from times described here:
https://www.baeldung.com/java-hashset-arraylist-contains-performance
List -> O(mn)
HashSet -> O(n)

Finally, I will merge this, so thanks for your PR