Fix RSA public key parser #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue is a regression with #2284. Before the spring-security-jwt parser was used and now nimbus, but is stricter in parser of key content. Implemented now the less strict parser from the library. We want remove spring-security-jwt in near future, thus did not used library anymore Added test with example of YAML or DB config based oauth2 provider in parameter tokenKey. The key there does not have line break but spaces or other chars.
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/185221408 The labels on this github issue will be updated when the story is started. |
…s more generic key parser
adrianhoelzl-sap
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue is a regression with #2284. Before the spring-security-jwt parser was used and now nimbus. Nimbus JOSE is stricter in parser of key content.
Implemented now the less strict parser from the library. We want remove spring-security-jwt in near future, thus did not used library anymore Added test with example of YAML or DB config based oauth2 provider in parameter tokenKey. The key there does not have line break but spaces or other chars.