Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UAA startup if postgresql is used for session store #2414

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

strehle
Copy link
Member

@strehle strehle commented Jul 24, 2023

found by accident on postgresql startup
Same as #1769 but then we cannot use database session store for postgresql. Without base64, it works, see
spring-projects/spring-session#1201 Because null value would be written into postgresql with error, see https://stackoverflow.com/questions/53160867/postgres-error-invalid-byte-sequence-for-encoding-utf8-0xca-0x2d

found by accident on postgresql startup
Same as #1769
but then we cannot use database session store for postgresql.
Without base64, it works, see
spring-projects/spring-session#1201
Because null value would be written into postgresql with error, see
https://stackoverflow.com/questions/53160867/postgres-error-invalid-byte-sequence-for-encoding-utf8-0xca-0x2d
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/185676060

The labels on this github issue will be updated when the story is started.

@strehle strehle linked an issue Jul 24, 2023 that may be closed by this pull request
@strehle strehle changed the title Fix UAA startup Fix UAA startup if postgresql is used for session store Jul 24, 2023
@strehle
Copy link
Member Author

strehle commented Jul 24, 2023

if postgresql is used for session store set in uaa.yml
servlet.session-cookie.encode-base64 : false
e.g.

servlet:
  session-cookie:
    encode-base64: false

@strehle strehle requested review from Tallicia and a team July 24, 2023 10:10
Copy link
Contributor

@hsinn0 hsinn0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So both this and the related uaa-release change keep the default as base64 encoding. That is good enough then.

@strehle strehle merged commit 0b57203 into develop Jul 26, 2023
20 checks passed
@strehle strehle deleted the fix/cookieBase64 branch July 26, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

PSQLException on starting UAA
3 participants