feature: Use custom key in private_key_jwt towards OAuth2/OIDC IdP #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/185685964 The labels on this github issue will be updated when the story is started. |
|
sonar green: documentation |
hsinn0
requested changes
Jul 25, 2023
server/src/test/java/org/cloudfoundry/identity/uaa/oauth/jwt/JwtClientAuthenticationTest.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/cloudfoundry/identity/uaa/oauth/jwt/JwtClientAuthenticationTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/cloudfoundry/identity/uaa/mock/providers/IdentityProviderEndpointDocs.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/cloudfoundry/identity/uaa/mock/providers/IdentityProviderEndpointDocs.java
Show resolved
Hide resolved
…tClientAuthentication/customKey
|
@hsinn0 Thanks for the review. I changed the text. |
|
Documentation Update |
hsinn0
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: Key rotation in UAA should be Independent from scenario.
Currently: UAA stores keys (JWKSet) in jwt.token.policy.keys.
The current signing key is defined with jwt.token.policy.activeKeyId.
This key is used for JWT creation towards UAA clients (standard token flows), but also with private_key_jwt for the JWT creation towards the IdP.
In case of key rotation this can be less flexible than situation before where secrets were used. Each IdP had a custom relyingPartySecret, different to the client secret of the oauth2 clients in UAA.
Therefore this PR introduces a sub parameter kid which allows to use a different key for private_key_jwt scenario.
With this the UAA clients can rotate keys without dependency to the configured identity providers in UAA:
The key used in private_key_jwt must be in zone configuration -> jwt.token.policy.keys.