Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused script & dockerfile #2422

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

peterhaochen47
Copy link
Member

  • This script (scripts/docker_run) and this dockerfile (ci/image/*) do not appear to be used or maintained anymore.

- This script (scripts/docker_run) and this dockerfile (ci/image/*)
do not appear to be used or maintained anymore.

Co-authored-by: Danny Faught <dfaught@vmware.com>
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/185694158

The labels on this github issue will be updated when the story is started.

@peterhaochen47 peterhaochen47 requested a review from a team July 25, 2023 23:47
@strehle
Copy link
Member

strehle commented Jul 26, 2023

The Dockerfile at least was helpful in past because if pipeline issues occurred I could there steps with it, e.g. Download of java or chromedriver etc....
Can we have the current Dockerfile in an example directory at least ?

@peterhaochen47
Copy link
Member Author

peterhaochen47 commented Jul 26, 2023

Hi @strehle, I see.
This docker image is not the docker image used in CIs, though it might look similar to the docker images used in the CIs because it was likely based on them when it was created. As this image is not maintained, it has diverged quite a bit from the CI docker images. So its usefulness as an approximation of what's happening in CI is diminishing. So I still advocate for the deletion of these files in this PR, as they are no longer maintained/kept up to date. If you wish to see these files for context, they are still preserved in git history.

We do try to fix CI errors ASAP. But if you wish to participate in CI fixing, that would be great! And I do recognize the problem that you don't have access to the CI repo (including the actual docker images); we should try to think about how to solve that problem (potentially by extracting credentials & any proprietary info from the CI repo, and making the CI repo public; or by moving the dockerfiles somewhere public).

Copy link
Member

@strehle strehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@peterhaochen47 peterhaochen47 merged commit ad89d72 into develop Jul 26, 2023
19 of 20 checks passed
@peterhaochen47 peterhaochen47 deleted the pr/delete-unused-script-and-image branch July 26, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants