Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: publish in well-known and document private_key_jwt parameters in rest API #2509

Merged
merged 9 commits into from
Oct 18, 2023
Merged

feature: publish in well-known and document private_key_jwt parameters in rest API #2509

merged 9 commits into from
Oct 18, 2023

Conversation

strehle
Copy link
Member

@strehle strehle commented Sep 28, 2023 •
edited
Loading

  • Use of client_secret is optional
  • Link to change JWT client

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/186142834

The labels on this github issue will be updated when the story is started.

@strehle strehle added this to the feature - private_key_jwt milestone Sep 28, 2023
@strehle strehle changed the title documentation: start to change and add parameters for private_key_jwt documentation: rest API of parameters for private_key_jwt Oct 3, 2023
@strehle strehle linked an issue Oct 17, 2023 that may be closed by this pull request
Support private_key_jwt from https://openid.net/specs/openid-connect-core-1_0.html#ClientAuthentication #2235
Closed
@hsinn0
Copy link
Contributor

hsinn0 commented Oct 17, 2023 •
edited
Loading

When I saw the title of this PR starting with "documentation:", I assumed that the change is documentation only. However, it contains more than documentation change.

@hsinn0 hsinn0 self-requested a review October 17, 2023 20:02
@strehle strehle changed the title documentation: rest API of parameters for private_key_jwt feature: publish in well-known and document private_key_jwt parameters in rest API Oct 18, 2023
@strehle
Copy link
Member Author

strehle commented Oct 18, 2023

When I saw the title of this PR starting with "documentation:", I assumed that the change is documentation only. However, it contains more than documentation change.

sorry, yes I started with documentation only but then found missing well-known adoption which belongs to the story, so should I devide this PR or rename PR ?

@strehle strehle requested a review from hsinn0 October 18, 2023 14:15
@strehle
Copy link
Member Author

strehle commented Oct 18, 2023

Thanks for your review

@hsinn0
Copy link
Contributor

hsinn0 commented Oct 18, 2023

When I saw the title of this PR starting with "documentation:", I assumed that the change is documentation only. However, it contains more than documentation change.

sorry, yes I started with documentation only but then found missing well-known adoption which belongs to the story, so should I devide this PR or rename PR ?

Looks like u renamed it, so it is good now.

@strehle strehle merged commit 41165e0 into develop Oct 18, 2023
21 checks passed
@strehle strehle deleted the feature/issue/2235/clientAuthApiDocs branch October 18, 2023 17:41
@cf-gitbot cf-gitbot added delivered accepted Accepted the issue and removed delivered labels Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsinn0 hsinn0 hsinn0 approved these changes

@adrianhoelzl-sap adrianhoelzl-sap adrianhoelzl-sap approved these changes

@torsten-sap torsten-sap Awaiting requested review from torsten-sap

@Tallicia Tallicia Awaiting requested review from Tallicia

Assignees
No one assigned
Labels
accepted Accepted the issue
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
feature - private_key_jwt
Development

Successfully merging this pull request may close these issues.

Support private_key_jwt from https://openid.net/specs/openid-connect-core-1_0.html#ClientAuthentication
4 participants
@strehle @cf-gitbot @hsinn0 @adrianhoelzl-sap