Make it easier to find test failures in CI output #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Searching for "FAILED" in the CI output always found this method, whether it failed or not.
* JUnit 5 has a better way to assert on an expected exception. * Cleaned up an unncessary type specification. * Fixed a typo. * Cleaned up an import.
* Trying to make it easier to search for "FAILED" in the CI output to find failed tests. * Also tried to make the message easier to understand.
swalchemist
requested review from
Tallicia,
bruce-ricard,
strehle,
peterhaochen47,
tack-sap,
torsten-sap and
hsinn0
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/186153618 The labels on this github issue will be updated when the story is started. |
hsinn0
reviewed
Sep 30, 2023
Web browsers make it difficult to do a case-sensitive search. Also, there are a few refactors here that I think are worthwhile. |
bruce-ricard
requested changes
Oct 2, 2023
There was a problem hiding this comment.
I like the idea for the change. Thank you for doing this.
I myself committed a similar change several years ago.
Mostly requesting changing because of the FAILURE commit that I don't understand.
...udfoundry/identity/uaa/authentication/manager/DynamicZoneAwareAuthenticationManagerTest.java
Outdated
Show resolved
Hide resolved
metrics-data/src/test/java/org/cloudfoundry/identity/uaa/util/JsonUtilsTest.java
Show resolved
Hide resolved
metrics-data/src/test/java/org/cloudfoundry/identity/uaa/util/JsonUtilsTest.java
Show resolved
Hide resolved
* The meaning of the name "retryFailOnPassedAfterRetry" was difficult to understand. It causes the full test run to fail when a flaky test is detected (both passes and fails on multiple runs). * Seems the indirection is required, first setting and checking a variable, then setting the "failOnPassedAfterRetry" property used by the retry plugin.
swalchemist
force-pushed
the
refactor-fail-output
branch
from
f792b9d
to
531db67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searching for "FAILURE" in the CI output in a browser (case insensitive) to find failed tests always finds things that aren't test failures. This PR applies the principle of never logging the word "failure" except when JUnit is reporting a test failure.
"Fail" is still ok to include in method names and other output.
Two additional refactors in the affected code are also included.