refactor two SAML tests to use page objects #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/186253006 The labels on this github issue will be updated when the story is started. |
swalchemist
force-pushed
the
samlTestRefactor
branch
2 times, most recently
from
3b1ca12
to
7f1cab0
Compare
|
@swalchemist, have you looked into the check failures yet? |
Checking. |
swalchemist
force-pushed
the
samlTestRefactor
branch
from
9d280b1
to
74ce740
Compare
swalchemist
changed the title
|
I removed the problematic test. All looks good and ready for review. |
strehle
approved these changes
Oct 28, 2023
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/HomePage.java
Outdated
Show resolved
Hide resolved
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/HomePage.java
Outdated
Show resolved
Hide resolved
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/LoginPage.java
Show resolved
Hide resolved
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/LogoutDoEndpoint.java
Outdated
Show resolved
Hide resolved
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/Page.java
Show resolved
Hide resolved
uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/SamlErrorPage.java
Outdated
Show resolved
Hide resolved
…FromSaml and testSingleLogoutWithLogoutRedirect
This is no inheritance of these classes that need the constant to be accessible.
* Trying to indicate that the action after "_" in the names are the result, not an action taken directly by the test. * Naming pattern: action_resultingPage().
* Make it clearer that we're going to the logout.do service.
swalchemist
force-pushed
the
samlTestRefactor
branch
from
0570028
to
44f047f
Compare
* They're associated with web API endpoints, so they don't belong with the pages.
Co-authored-by: Bruce Ricard <bricard@vmware.com>
* Trying to reduce confusion - this gets the home url but never actually loads the home page html.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert 2 tests to use the page object strategy:
incorrectResponseFromSamlIDP_showErrorFromSaml
testSingleLogoutWithLogoutRedirect