Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return invalid_client in oauth2 error code #2596

Merged
merged 1 commit into from
Nov 17, 2023
Merged

return invalid_client in oauth2 error code #2596

merged 1 commit into from
Nov 17, 2023

Conversation

strehle
Copy link
Member

@strehle strehle commented Nov 13, 2023

return invalid_client in oauth2 error response body

Fix for issue #2545

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/186464529

The labels on this github issue will be updated when the story is started.

@strehle
Copy link
Member Author

strehle commented Nov 13, 2023

alternative PR to #2575

@strehle strehle linked an issue Nov 13, 2023 that may be closed by this pull request
Error response code not compliant to RFC 6749 #2545
Closed
@strehle
return invalid_client in oauth2 error code
82b62f9 
return invalid_client in oauth2 error response body

Fix for issue #2545
@strehle strehle added in_review The PR is currently in review clarification needed The issue is not accepted but we need clarification labels Nov 15, 2023
@hsinn0
Copy link
Contributor

hsinn0 commented Nov 15, 2023 •
edited
Loading

alternative PR to #2575

What does this mean? Do you want reviewers pick one between this PR and #2575, which apparently is in progress?

@strehle strehle added this to the 76.26.0 milestone Nov 16, 2023
@strehle strehle mentioned this pull request Nov 16, 2023
Closed
@strehle strehle requested a review from a team November 16, 2023 17:20
@strehle strehle mentioned this pull request Nov 16, 2023
Closed
@strehle strehle removed the clarification needed The issue is not accepted but we need clarification label Nov 16, 2023
hsinn0
hsinn0 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@hsinn0 hsinn0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, with the expectation this change to be mentioned in the release note as discussed during our sync-up meeting.

@strehle strehle merged commit f55b95a into develop Nov 17, 2023
20 checks passed
@strehle strehle deleted the fix/issue/2545-2 branch November 17, 2023 06:36
@cf-gitbot cf-gitbot added delivered accepted Accepted the issue and removed delivered labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsinn0 hsinn0 hsinn0 approved these changes

@Tallicia Tallicia Awaiting requested review from Tallicia

@bruce-ricard bruce-ricard Awaiting requested review from bruce-ricard

Assignees
No one assigned
Labels
accepted Accepted the issue in_review The PR is currently in review
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
76.26.0
Development

Successfully merging this pull request may close these issues.

Error response code not compliant to RFC 6749
3 participants
@strehle @cf-gitbot @hsinn0