Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove a SAML dependency #2699

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

bruce-ricard
Copy link
Contributor

  • We are getting rid of this constant because it is in the SAML extension library that we are trying to remove.

  • As far as we can tell, this ACR doesn't need to be any specific string. The set just needs to contain one element.

#186822654

* We are getting rid of this constant because it is in the SAML
  extension library that we are trying to remove.

* As far as we can tell, this ACR doesn't need to be any specific
  string. The set just needs to contain one element.

[#186822654](https://www.pivotaltracker.com/story/show/186822654)

Co-Authored-by: Bruce Ricard <bruce.ricard@google.com>
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/186957460

The labels on this github issue will be updated when the story is started.

@bruce-ricard bruce-ricard added the saml-extension-replacement Work related to the replacement of the old SAML extension library by the newer spring security label Jan 31, 2024
@swalchemist swalchemist merged commit d0b75bb into develop Feb 6, 2024
20 checks passed
@swalchemist swalchemist deleted the refactorDeprecatedTokenTests branch February 6, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
saml-extension-replacement Work related to the replacement of the old SAML extension library by the newer spring security
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants