-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: clean up unused DB table service_provider #2701
feat: clean up unused DB table service_provider #2701
Conversation
- This table was added for the UAA-as-SAML-IDP feature (b93c87a) - This feature has been removed: #2638. Hence this table is now unused. - The "DROP TABLE IF EXISTS" syntax would not error out if the table does not exist, compared to just "DROP TABLE". - Also clean up docs and a test util that reference this table. [#182118433]
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/186960080 The labels on this github issue will be updated when the story is started. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@strehle FYI - I believe this is expected to be included before the v77 release as part of the breaking changes for the SAML IdP removal. |
@peterhaochen47 I have seen this also during review of #2638 but I thought you wanted wait with the removal. My assumption was that maybe we wait an additional release until removing the DB table because if we remove data we cannot revert to the older version. Therefore I thought it was wanted to not removing the table, however from my side we can also remove it and then release or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for SAP, but see my comments about this step.... if we delete the table, then the way back is not possible
I am also for not removing the table right away but waiting for a couple of releases or so. |
Given that this PR has 2 approvals (and that I just discussed this with my team and the team was mostly neutral but leaning toward merging), so I will opt to merge this & include it in UAA v77.0.0. |
[#182118433]