Misc SAML tests refactors #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187042229 The labels on this github issue will be updated when the story is started. |
- this test's prior name ("testSingleLogoutWithLogoutRedirect")
is misleading because it implies similar setup with another test
("testSingleLogout"), where SAML single logout is performed.
But in reality, this test is more similar to another test
("testSingleLogoutWithNoLogoutUrlOnIDP") where SAML single logout
is NOT performed. Hence, renaming the test to reflect that.
- no need to initialize a saml server as we are using a deployed saml server for this test - tests are all passing without these setup - remove unused imports
peterhaochen47
force-pushed
the
pr/develop/misc-saml-tests-refactors
branch
from
43f29c2
to
3e89cd0
Compare
* Two tests were not compiling because of one assertion in each, verifying that the SAML filter was not called. * The structure of the current production code makes the condition the assertions were looking for unlikely to fail. * We considered adding @ignore on the tests and fixing the assertions later, but decided to keep the tests running and just remove this small bit of test coverage. * Bruce previously expressed the opinion that we should remove the assertions. Co-authored-by: Peter Chen <peter-h.chen@broadcom.com>
* The tests pass without the call to samlTestUtils.initializeSimple(). * None of the tests seems to have anything to do with SAML.
swalchemist
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are intended to help with the replacement of the SAML extension library.