refactor: use non-deprecated saml configs in uaa.yml #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when starting local UAA for dev/test (./gradlew run or when running some integration tests locally) - the old fields, login.serviceProviderKey, login.serviceProviderKeyPassword and login.serviceProviderCertificate, are deprecated as this test shows: https://github.com/cloudfoundry/uaa/blob/1c19ffc2697441824d2e98e31210a82e1fbc0ac1/uaa/src/test/java/org/cloudfoundry/identity/uaa/login/BootstrapTests.java#L103 Their equivalent fields on uaa-release are also explicitly marked as deprecated: https://github.com/cloudfoundry/uaa-release/blob/aa1f85673f2b6560bb79551380a7edaf1e48aa83/jobs/uaa/spec#L1204-L1253 - migrate to using the new fields. After the change, manually verified that the output of http://localhost:8080/uaa/saml/metadata (into which these fields's values go) remains the same.
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187057640 The labels on this github issue will be updated when the story is started. |
swalchemist
reviewed
Feb 16, 2024
swalchemist
approved these changes
Feb 16, 2024
peterhaochen47
deleted the
pr/develop/use-newer-saml-configs-for-local-uaa
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uaa/uaa/src/test/java/org/cloudfoundry/identity/uaa/login/BootstrapTests.java
Line 103 in 1c19ffc