Move IdP Alias Handling to separate Class #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187079914 The labels on this github issue will be updated when the story is started. |
klaus-sap
reviewed
Feb 21, 2024
| && existingEntity.getAliasZid().equals(requestBody.getAliasZid()); | ||
| } | ||
|
|
||
| // alias ID must not be set when no alias existed already |
There was a problem hiding this comment.
caller must not choose alias ID, instead new alias ID will be generated
klaus-sap
approved these changes
Feb 21, 2024
hsinn0
reviewed
Feb 26, 2024
| void setAliasId(String aliasId); | ||
|
|
||
| @Nullable | ||
| String getAliasZid(); |
There was a problem hiding this comment.
I suppose that aliasZid is aliasZoneId, right? Might be better to either document it (javadoc) or rename the property to something clearer?
There was a problem hiding this comment.
Added Javadoc comments in commit 0197893
hsinn0
approved these changes
Feb 27, 2024
torsten-sap
deleted the
feature/move-idp-alias-handling-to-separate-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #2505
Move the handling of alias IdPs to a separate class so that it can be re-used for the future alias feature for SCIM users.