Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependency org.seleniumhq.selenium:selenium-java to v4.18.1 #2744

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

strehle
Copy link
Member

@strehle strehle commented Feb 23, 2024

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/187102787

The labels on this github issue will be updated when the story is started.

@strehle
Copy link
Member Author

strehle commented Feb 23, 2024

The selenium driver is mainly used in UI tests ... you worked in past with SAML tests so update should help in order to prevent issues with webdriver

@strehle
Copy link
Member Author

strehle commented Feb 27, 2024

@swalchemist do you want to review it ? it is no code change but simply allows to update selenium more often

@hsinn0
Copy link
Contributor

hsinn0 commented Feb 27, 2024

It is a good change as the two dependency's versions are different.

Copy link
Contributor

@swalchemist swalchemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that the first commit broke the unit tests, and the second commit fixes them. More context in the commit message would help future developers understand what happened. Is selenium-http-jdk-client:4.18.1 incompatible with selenium-java 4.18.1, or with our code somewhere?

@strehle
Copy link
Member Author

strehle commented Feb 27, 2024

selenium-http-jdk-client

no there is simply no http client with same version, happed by acciddent that 4.13.x had same version

@strehle strehle merged commit 2fab51c into develop Feb 29, 2024
20 checks passed
@strehle strehle deleted the selenium4181 branch February 29, 2024 19:18
@cf-gitbot cf-gitbot added delivered accepted Accepted the issue and removed delivered labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Accepted the issue
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants