-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependency org.seleniumhq.selenium:selenium-java to v4.18.1 #2744
Conversation
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187102787 The labels on this github issue will be updated when the story is started. |
The selenium driver is mainly used in UI tests ... you worked in past with SAML tests so update should help in order to prevent issues with webdriver |
@swalchemist do you want to review it ? it is no code change but simply allows to update selenium more often |
It is a good change as the two dependency's versions are different. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that the first commit broke the unit tests, and the second commit fixes them. More context in the commit message would help future developers understand what happened. Is selenium-http-jdk-client:4.18.1 incompatible with selenium-java 4.18.1, or with our code somewhere?
# Conflicts: # dependencies.gradle
no there is simply no http client with same version, happed by acciddent that 4.13.x had same version |
https://www.selenium.dev/downloads/
https://github.com/SeleniumHQ/selenium/blob/trunk/java/CHANGELOG