-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load jwtClientAuthentication in uaa.yml #2758
Conversation
By mistake the variable jwtclientAuthentication was used in PR for clientAuthentication. Documentation explain jwtClientAuthentication as entry
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187161959 The labels on this github issue will be updated when the story is started. |
Before I look at this PR, I want to understand the original issue first. See comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...r/src/main/java/org/cloudfoundry/identity/uaa/provider/oauth/OauthIDPWrapperFactoryBean.java
Show resolved
Hide resolved
...r/src/main/java/org/cloudfoundry/identity/uaa/provider/oauth/OauthIDPWrapperFactoryBean.java
Show resolved
Hide resolved
...cloudfoundry/identity/uaa/provider/oauth/OauthIdentityProviderDefinitionFactoryBeanTest.java
Show resolved
Hide resolved
...r/src/main/java/org/cloudfoundry/identity/uaa/provider/oauth/OauthIDPWrapperFactoryBean.java
Show resolved
Hide resolved
...r/src/main/java/org/cloudfoundry/identity/uaa/provider/oauth/OauthIDPWrapperFactoryBean.java
Show resolved
Hide resolved
Thanks @strehle! I personally think that fixing the code to be aligned with the correct case-sensitive field What do you think? Are there a lot of adoptions of the incorrect |
No I am sure, that not many adoptions out with incorrect setting, but with this PR both settings would be used But I asked me to change this PR so that only the correct setting is used? |
Simply correcting the code to comply with the doc (without being compatible with the incorrect |
Ok, then I would like to stay with current code. In current code jwtClientAuthentication is used first, so no extra step if correct name is used, but for others jwtclientAuthentication would still work |
By mistake the variable jwtclientAuthentication was used in PR for clientAuthentication.
Documentation explains jwtClientAuthentication as entry