feat: Use Database availability as indicator for /healthz response #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hzDatabaseCheck"" This reverts commit aa8349f.
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187164125 The labels on this github issue will be updated when the story is started. |
|
@Tallicia @swalchemist Could you please review as you were already involved in the initial PR? |
tack-sap
force-pushed
the
feat/healthzDatabaseCheckBackwardsCompatible
branch
from
aff08ce
to
0a56dc2
Compare
|
I will take look. |
swalchemist
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the original PR #2718 got reverted, here the next try to implement a /healthz that uses database availability as idicator for the response.
The difference in this PR is, that the response for the "happy case" is not changed and thus backwards compatible (like the original PR initially also tried before the more detailed status messages were introduced).