more methods for sanitized logging #2764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187173417 The labels on this github issue will be updated when the story is started. |
adrianhoelzl-sap
approved these changes
Mar 5, 2024
|
Currently sonar has issue with last change see So I think we should first fix / clarify, why sonar now is alerting before enhancing this I started with #2760 but not if it solves all |
strehle
previously requested changes
Mar 5, 2024
server/src/main/java/org/cloudfoundry/identity/uaa/logging/SanitizedLogFactory.java
Outdated
Show resolved
Hide resolved
strehle
reviewed
Mar 6, 2024
server/src/main/java/org/cloudfoundry/identity/uaa/logging/SanitizedLogFactory.java
Outdated
Show resolved
Hide resolved
strehle
previously requested changes
Mar 6, 2024
server/src/main/java/org/cloudfoundry/identity/uaa/logging/SanitizedLogFactory.java
Outdated
Show resolved
Hide resolved
strehle
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
thanks, no suppress but green
https://sonarcloud.io/summary/new_code?id=cloudfoundry-identity-parent&pullRequest=2764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sonarcloud.io/summary/new_code?id=cloudfoundry-identity-parent&pullRequest=2764