Fix uaa start. Prevent exception if encryption section missing #2767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The encryption service is not usable if no passphrase set, but that service is not in use at all - currently.
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187182262 The labels on this github issue will be updated when the story is started. |
The encryption service is not usable if no passphrase set, but that service is not in use at all - currently.
|
Summary of OSS sync: this was for MFA feature (which is already removed); hence these fields are currently unused. But this PR keeps them in case there is future usage. |
|
@peterhaochen47 @Tallicia can you please take this PR in review. For us it means less Ops but for UAA there is no risk to break something, because these classes are not in use - but they need a secret key currently |
strehle
changed the title
Tallicia
reviewed
Mar 18, 2024
| @@ -44,4 +46,9 @@ public void decrypt_shouldNotDecryptWithInvalidPassphrase() throws EncryptionSer | |||
| assertThat(ciphertext, is(notNullValue())); | |||
| new EncryptionService("invalid-password").decrypt(ciphertext); | |||
| } | |||
|
|
|||
| @Test | |||
| public void initShouldWorkWithEmptyKey() { | |||
Tallicia
reviewed
Mar 18, 2024
| } | ||
|
|
||
| @Test | ||
| public void shouldNotThrowErrorIfNoActiveKeyLabelIsProvided() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The encryption service is not usable if no passphrase set, but that service is not in use at all - currently.