Misc API docs improvements #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187296940 The labels on this github issue will be updated when the story is started. |
strehle
reviewed
Mar 23, 2024
...src/test/java/org/cloudfoundry/identity/uaa/mock/providers/IdentityProviderEndpointDocs.java
Outdated
Show resolved
Hide resolved
- experiments show that UAA returns JWTs when token_format is not specified, regardless of what the value of uaa.yml `jwt.token.revocable` (for non-default zones, `config.tokenPolicy.jwtRevocable`) is. - the code does read `jwt.token.revocable` when generating tokens (https://github.com/cloudfoundry/uaa/blob/9e9874075ab284aa7d23d14a01168c61dcafdc39/server/src/main/java/org/cloudfoundry/identity/uaa/oauth/UaaTokenServices.java#L618), but it does not impact the generated token's format. Co-authored-by: Peter Chen <peter-h.chen@broadcom.com>
- clarify that this field is always null (instead of explaining a lot about the various formats of the access token when no access token will be returned) Co-authored-by: Peter Chen <peter-h.chen@broadcom.com>
peterhaochen47
force-pushed
the
pr/develop/misc-api-docs-improvements
branch
from
a6d43bd
to
e891c09
Compare
strehle
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.