Prevent Update and Delete of Entities with Alias if Alias Feature is disabled #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187323121 The labels on this github issue will be updated when the story is started. |
adrianhoelzl-sap
added
the
DO NOT MERGE
…gAlias -> shouldAccept_ShouldIgnoreDanglingReference (renamed to "shouldReject_EvenIfAliasReferenceIsBroken")
adrianhoelzl-sap
force-pushed
the
feature/prevent-update-and-delete-of-entities-with-alias-if-alias-feature-disabled
branch
from
60d73b0
to
2b116b9
Compare
…gAlias -> shouldAccept_SetAliasPropertiesToNullAndChangeOtherProperties (renamed to "shouldReject_SetAliasPropertiesToNullAndChangeOtherProperties")
…gAlias -> shouldAccept_SetOnlyAliasPropertiesToNull (renamed to "shouldReject_SetOnlyAliasPropertiesToNull")
…gAlias -> shouldAccept_ShouldIgnoreAliasIdOfExistingIdpMissing (renamed to "shouldReject_AliasIdOfExistingIdpMissing")
…tyProviderEndpointsAliasMockMvcTests
…an alias exists but the alias feature is disabled
…bled and IdP has alias
adrianhoelzl-sap
commented
Apr 3, 2024
adrianhoelzl-sap
removed
the
DO NOT MERGE
hsinn0
reviewed
Apr 4, 2024
server/src/main/java/org/cloudfoundry/identity/uaa/alias/EntityAliasHandler.java
Show resolved
Hide resolved
server/src/main/java/org/cloudfoundry/identity/uaa/alias/EntityAliasHandler.java
Show resolved
Hide resolved
server/src/test/java/org/cloudfoundry/identity/uaa/alias/EntityAliasHandlerValidationTest.java
Show resolved
Hide resolved
…ityAliasHandler.ensureConsistencyOfAliasEntity
hsinn0
approved these changes
Apr 5, 2024
adrianhoelzl-sap
deleted the
feature/prevent-update-and-delete-of-entities-with-alias-if-alias-feature-disabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #2505
Prevent update and deletion of identity providers that have an alias if the alias feature is disabled again (i.e.,
aliasEntitiesEnabledis set tofalse).