Move OAuth2 classes BaseClientDetails to UaaClientDetails #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187329458 The labels on this github issue will be updated when the story is started. |
strehle
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
model/src/main/java/org/cloudfoundry/identity/uaa/client/UaaBaseClientDetails.java
Fixed
Show fixed
Hide fixed
because of parallel tests
strehle
changed the title
strehle
changed the title
strehle
changed the title
hsinn0
requested changes
Apr 4, 2024
model/src/main/java/org/cloudfoundry/identity/uaa/client/Jackson2ArrayOrStringDeserializer.java
Show resolved
Hide resolved
…auth2/client-persistency-move
hsinn0
approved these changes
Apr 5, 2024
…/client-persistency-move
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the classes because finally we want remove https://github.com/cloudfoundry/uaa/blob/develop/dependencies.gradle#L14
The classes here represent the persistence of UAA. Moved only the classes but not the interfaces yet.
The interfaces used in many other library methods but finally the interfaces will be moved also next to the classes here
The BaseClientDetails class does not know jwtClientConfig field of UAA but now UaaClientDetails class know
Added tests for the base classes and changed many imports