Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests for EntityAliasHandler.ensureConsistencyOfAliasEntity #2824

Merged
merged 20 commits into from
Apr 17, 2024
Merged

Refactor tests for EntityAliasHandler.ensureConsistencyOfAliasEntity #2824

merged 20 commits into from
Apr 17, 2024

Commits on Apr 11, 2024

  1. Add superclass for tests for EntityAliasHandler.ensureConsistencyOfAl… 

    …iasEntity
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    5fb1518 View commit details
    Browse the repository at this point in the history

  2. Move customZoneId generation to superclass

    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    e6f1a72 View commit details
    Browse the repository at this point in the history

  3. Add inner classes for different combinations of existing/non-existing… 

    … alias and alias feature enabled/disabled
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    767c967 View commit details
    Browse the repository at this point in the history

  4. Move IdpWithAliasMatcher to superclass and make it generic

    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    87b0046 View commit details
    Browse the repository at this point in the history

  5. Refactor

    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    5d41d70 View commit details
    Browse the repository at this point in the history

  6. Use correct import for "assertThatExceptionOfType"

    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    a0c9c02 View commit details
    Browse the repository at this point in the history

  7. Move "shallowCloneEntity" to test superclass

    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    998ba12 View commit details
    Browse the repository at this point in the history

  8. Move "arrangeZoneDoesNotExist" to test superclass

    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    9e71418 View commit details
    Browse the repository at this point in the history

  9. Move creation of aliasHandler to test superclass

    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    b6e4598 View commit details
    Browse the repository at this point in the history

  10. Move 'entitiesAreEqual' and 'changeNonAliasProperties' to test superc… 

    …lass
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    d58146f View commit details
    Browse the repository at this point in the history

  11. Move 'NoExistingAliasBase' to test superclass

    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    271aa06 View commit details
    Browse the repository at this point in the history

  12. Use test superclass for each combination of enabled/disabled alias fe… 

    …ature and existing/non-existing alias
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    21e3c78 View commit details
    Browse the repository at this point in the history

  13. Move 'arrangeEntityExists' and 'arrangeEntityDoesNotExist' to test su… 

    …perclass
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    bdc7f73 View commit details
    Browse the repository at this point in the history

  14. Move 'NoExistingAlias' -> 'AliasFeatureEnabled' -> 'shouldThrow_WhenA… 

    …liasZidSetButZoneDoesNotExist' to superclass
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    0c82134 View commit details
    Browse the repository at this point in the history

  15. Move 'ExistingAlias' -> 'AliasFeatureDisabled' -> 'shouldThrow_IfExis… 

    …tingEntityHasAlias' to superclass
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    e584467 View commit details
    Browse the repository at this point in the history

  16. Add test 'ExistingAlias' -> 'AliasFeatureDisabled' -> 'shouldThrow_Ev… 

    …enIfNoAliasPropertyIsChanged' to superclass
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    8ce9106 View commit details
    Browse the repository at this point in the history

  17. Refactor

    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c500307 View commit details
    Browse the repository at this point in the history

  18. Move 'ExistingAlias' -> 'AliasFeatureEnabled' -> 'shouldThrow_WhenRef… 

    …erencedAliasIdpAndAliasZoneDoNotExist' to superclass
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    6badead View commit details
    Browse the repository at this point in the history

  19. Add test 'NoExistingAlias' -> 'AliasFeatureDisabled' -> 'shouldThrow_… 

    …WhenAliasZidSet' to test superclass
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    f39f67b View commit details
    Browse the repository at this point in the history

  20. Move test 'NoExistingAlias' -> 'AliasFeatureEnabled' -> 'shouldCreate… 

    …NewAliasEntity_WhenAliasZoneExistsAndAliasPropertiesAreSet' to test superclass
    @adrianhoelzl-sap
    adrianhoelzl-sap committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    541d13a View commit details
    Browse the repository at this point in the history