Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load static resources from default zone if zone not found #2828

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

tack-sap
Copy link
Contributor

This was already addressed with #979, but the fix there only works for a local setup. In a typical productive deployment, the path is not starting with /uaa/, so the check need to be adopted to work in both local environment and a deployment.

This was already addressed with #979, but the fix there only works for a local setup.
In a typical productive deployment, the path is not starting with /uaa/, so the check need to be adopted to work in both local environment and a deployment.
@tack-sap tack-sap requested a review from strehle April 15, 2024 14:59
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/187432616

The labels on this github issue will be updated when the story is started.

@strehle
Copy link
Member

strehle commented Apr 15, 2024

Now
https://none.login.uaa-acceptance.cf-app.com/

image

After the goal is, show error

image

@strehle strehle requested a review from a team April 15, 2024 16:23
@strehle strehle requested a review from a team April 15, 2024 16:24
@strehle
Copy link
Member

strehle commented Apr 15, 2024

@strehle strehle merged commit 78e2a47 into develop Apr 16, 2024
20 checks passed
@strehle strehle deleted the fix/idzNotFoundErrorPage branch April 16, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants