Refactoring: testable code in JdbcScimUserProvisioning #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create bean for extra SimpleSearchQueryConverter * Need an extra SimpleSearchQueryConverter for the search with join but this object can be created once. * Need NamedParameterJdbcTemplate for the search but this object can be created once * Removed interface methods which are never used Created JUnit tests for all cases in retrieveByScimFilterOnlyActive and verify the existence of LOWER
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187536128 The labels on this github issue will be updated when the story is started. |
strehle
commented
May 2, 2024
| @@ -43,6 +44,10 @@ public void setQueryConverter(SearchQueryConverter queryConverter) { | |||
| this.queryConverter = queryConverter; | |||
| } | |||
|
|
|||
| public void setNamedParameterJdbcTemplate(NamedParameterJdbcTemplate namedParameterJdbcTemplate) { | |||
There was a problem hiding this comment.
this can be removed / refactored, if #2864 is merged before
adrianhoelzl-sap
approved these changes
May 2, 2024
swalchemist
reviewed
May 3, 2024
server/src/main/java/org/cloudfoundry/identity/uaa/scim/jdbc/JdbcScimUserProvisioning.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/cloudfoundry/identity/uaa/scim/jdbc/JdbcScimUserProvisioning.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/cloudfoundry/identity/uaa/resources/jdbc/SimpleSearchQueryConverter.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/cloudfoundry/identity/uaa/resources/JoinAttributeNameMapper.java
Show resolved
Hide resolved
becaue of refactoring from review
swalchemist
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create bean for extra SimpleSearchQueryConverter
Need an extra SimpleSearchQueryConverter for the search with join but this object can be created once.
Need NamedParameterJdbcTemplate for the search but this object can be created once
Removed interface methods which are never used
Created JUnit tests for all cases in retrieveByScimFilterOnlyActive and verify the existence of LOWER
e.g.
https://www.baeldung.com/java-clean-code#characteristics_of_clean_code