New SAML 2024.05.30 - Not to merge but just for SAML feature branch testing #2908
+15,579
−10,838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tallicia
added
in progress
DO NOT MERGE
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187710947 The labels on this github issue will be updated when the story is started. |
Tallicia
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| String registrationId = request.getParameter(Saml2ParameterNames.RELAY_STATE); | ||
|
|
||
| String forwardUrl = DEFAULT_FILTER_FORWARD_URI_PREFIX.formatted(registrationId); | ||
| RequestDispatcher dispatcher = request.getRequestDispatcher(forwardUrl); |
Check failure
Code scanning / CodeQL
URL forward from a remote source High
duanemay
force-pushed
the
new-saml-0530
branch
5 times, most recently
from
65b0d64
to
e67a40a
Compare
duanemay
force-pushed
the
new-saml-0530
branch
9 times, most recently
from
a761b67
to
7de27a1
Compare
duanemay
force-pushed
the
new-saml-0530
branch
2 times, most recently
from
0d3a595
to
f199f50
Compare
peterhaochen47
force-pushed
the
new-saml-0530
branch
from
46248b9
to
290f89c
Compare
duanemay
force-pushed
the
new-saml-0530
branch
2 times, most recently
from
46248b9
to
b6cb65b
Compare
peterhaochen47
force-pushed
the
new-saml-0530
branch
2 times, most recently
from
a97457f
to
745fff3
Compare
prefix="login.saml" was in 2 ConfigProps classes before merged into 1
Reads provider info from database Passes the registrationId as relayState Signed-off-by: Prateek Gangwal <prateek.gangwal@broadcom.com>
when running multiple IT tests, the simplesamlphp2 link was also listed, and causing a conflict with url matcher Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com> Signed-off-by: Ivan Protsiuk <ivan.protsiuk@broadcom.com> #187106956
Signed-off-by: Ivan Protsiuk <ivan.protsiuk@broadcom.com>
- Improve Testing of SAML Request/Response with Saml2TestUtils - Configure assertionConsumerServiceLocation in one location. - Attempted move to OpenSaml4AuthenticationProvider requires a shadow dependency on opensaml to remove the need for non-FIPS compliant security provider. Not yet in place Signed-off-by: Duane May <duane.may@broadcom.com> Signed-off-by: Alicia Yingling <alicia.yingling@broadcom.com>
Move user shadowing, attribute processing, and authorities processing to their own classes. Enable Authorities Signed-off-by: Ivan Protsiuk <ivan.protsiuk@broadcom.com>
This provides general response validation. Signed-off-by: Prateek Gangwal <prateek.gangwal@broadcom.com>
Signed-off-by: Prateek Gangwal <prateek.gangwal@broadcom.com> #187809240
Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com> Signed-off-by: Hongchol Sinn <hongchol.sinn@broadcom.com>
Signed-off-by: Hongchol Sinn <hongchol.sinn@broadcom.com>
- Main logout flows are working - IDP Initiated logout is working - Handle metadata XML passed in instead of metadata location for both bootstrap and SamlIdentityProviderConfigurator Signed-off-by: Duane May <duane.may@broadcom.com>
- clean up the rest of the pageObjects package Signed-off-by: Duane May <duane.may@broadcom.com>
- now attempts to retrieve the non-existent url https://simplesamlphp.uaa.com/saml2/idp/metadata.php Signed-off-by: Duane May <duane.may@broadcom.com>
- Implemented to the same level as the default IdenityZone's SP metadata generation. - Minus `NameIDFormat` value populaition and registration-ID specific implementation. [#187846376]
…not valid anymore.
- No longer have Ignored tests only Disabled Signed-off-by: Duane May <duane.may@broadcom.com>
Signed-off-by: Duane May <duane.may@broadcom.com>
- correctly populates the basic fields of non-default zone SAML SP metadata (such as WantAssertionsSigned and AuthnRequestsSigned), so that for default vs. non-default zones, the SP metadatas have feature parity. [#187846376] Signed-off-by: Duane May <duane.may@broadcom.com> Signed-off-by: Peter Chen <peter-h.chen@broadcom.com>
peterhaochen47
force-pushed
the
new-saml-0530
branch
4 times, most recently
from
b58a599
to
4a0ddde
Compare
Signed-off-by: Peter Chen <peter-h.chen@broadcom.com>
peterhaochen47
force-pushed
the
new-saml-0530
branch
from
d5abae0
to
a21cd27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the other feature branch #2862 for new SAML library replacement effort.