Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SAML NameIDPolicy #439

Merged

Conversation

RoopGuron
Copy link
Contributor

Signed-off-by: Dario amiri@ge.com

Signed-off-by: Dario <amiri@ge.com>
@cfdreddbot
Copy link

Hey RoopGuron!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/129878457

The labels on this github issue will be updated when the story is started.

@RoopGuron
Copy link
Contributor Author

Add support for SAML NameIDPolicy
Summary of Changes:

  1. Enhanced the IDP metadata generation components to publish explicitly the UAA SAML IDP's NameID Policy.
  2. Enhanced the UAA IDP SAML Authentication Assertion to validate and if successful enumerate supported-requested NameID Format.
  3. Enhanced UAA SAML SP registration component to validate the registering service provider supports at least one UAA supported NameID formats.
  4. Added Tests for UAA SAML IDP NameID format.
  5. Added Tests for UAA SAML IDP based Authentication.
  6. Added Tests for UAA SAML SP NameID format.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 84.194% when pulling a3a62e6 on GESoftware-CF:saml_idp_email_nameid_support into 9b7139b on cloudfoundry:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 84.194% when pulling a3a62e6 on GESoftware-CF:saml_idp_email_nameid_support into 9b7139b on cloudfoundry:develop.

@coveralls
Copy link

coveralls commented Sep 6, 2016

Coverage Status

Coverage increased (+0.02%) to 84.281% when pulling a3a62e6 on GESoftware-CF:saml_idp_email_nameid_support into 9b7139b on cloudfoundry:develop.

@fhanik fhanik merged commit fbc5387 into cloudfoundry:develop Sep 6, 2016
@cf-gitbot cf-gitbot added delivered accepted Accepted the issue and removed delivered labels Sep 13, 2016
@6palace 6palace deleted the saml_idp_email_nameid_support branch November 23, 2016 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Accepted the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants