missing cookie switch #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey strehle! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/155191148 The labels on this github issue will be updated when the story is started. |
|
We actually do need the Current User cookie. It is used by the session_management.html page together with RP javascripts in uaa-singular for our implementation of OIDC session management. It seems if any change is needed here, it is to add assertions about the presence of Current User cookie to relevant integration tests. |
Closed
…ookie_switch * 'bug/cookie_switch' of github.com:strehle/uaa: Send account cookies only if idp discovery switch is on
|
Merged via 3ae3e72 Thanks for the PR! |
cf-gitbot
added
delivered
in progress
accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #774
This PR is a suggestion to omit the cookie.
The existance is required in mock tests but only in mocks not integration tests