Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add a new task to deploy demo to GitHub Pages #72

Merged
merged 1 commit into from
Jun 8, 2016

Conversation

erikjung
Copy link
Contributor

@erikjung erikjung commented Jun 8, 2016

Re: #70

This adds the Option B solution.

gulp build
gulp demo

The contents of .dist will be committed and pushed to the gh-pages branch, and viewable at http://cloudfour.github.io/drizzle/

NOTE: I first attempted to have the cacheDir (demo) be the same as dist, but the Gulp plugin had issues with that. I might be possible though, for future improvement.

@gerardo-rodriguez
Copy link
Member

Awesome! I didn't try it locally, but LGTM! 👍

@tylersticka
Copy link
Member

@erikjung You can avoid the demo directory if you just use the gh-pages package (no Gulp plugin). Example: https://github.com/cloudfour/svg-icon-example/blob/master/gulpfile.js#L58-L60

@erikjung
Copy link
Contributor Author

erikjung commented Jun 8, 2016

@tylersticka As mentioned in Slack...

I attempted to use the gh-pages package instead, and experienced some issues with the dist path. I think it was likely just my working copy, but I'm going to keep it as-is for now (using the Gulp package).

We can switch it up later.

@erikjung erikjung closed this Jun 8, 2016
@erikjung erikjung reopened this Jun 8, 2016
@tylersticka
Copy link
Member

LGTM 👍

@erikjung erikjung merged commit 4f1a0f9 into master Jun 8, 2016
@erikjung erikjung mentioned this pull request Jun 8, 2016
@calebeby calebeby deleted the feat-demo_task branch June 21, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants