1.1.5 broke relative paths

[geddski]

Relative paths are broken in 1.1.5 in less.js in the browser, works fine in Node.

For example:

main.less

body{
  background: url("badger.jpg");
}

When compiled with Node the url will be relative to the LESS file, as it should be. When evaluated in the browser with less.js it's relative to the html file, causing a 404 not found on the image.

Relative paths work just fine in 1.1.4. I ran a git bisect and narrowed it down to this commit: (dist) version bump & build 1.1.5

This is a pretty critical bug, appearing all over the place. Duplicates of this issue:
Issue #464
Issue #471
issue 465

Please address.

[cloudhead]

Hmm weird.

That commit is just the build commit, so it'll include all commits between 1.1.4 -> 1.1.5... doesn't help..

I'll look into it though.

[geddski]

Yeah that's the weird thing - I stepped through all the commits of
1.1.4 and it didn't have this bug. 1.1.5 suddenly had it on that first
build commit. Wish I could have narrowed it down further.

[cloudhead]

Here it is: 1751f13#L0R8

The author didn't patch the regex properly, making it all optional and I didn't catch the mistake when I merged.

I pushed the fix.

[cmyk]

Won't work in this case:
I have the style.css in the same directory as the images folder:
@{base-url}:"";
.signal_image.a2 { background-image: url("@{base-url}images/ampel2.png");}

This works, though:
@{base-url}:"images/";
.signal_image.a2 { background-image: url("@{base-url}ampel2.png");}

[cmwelsh]

This is a very serious bug for those who use LESS extensively in the browser. Please push out a new minor version so people don't waste time debugging this later on.

[geddski]

He did, it's fixed (mostly). Importing regular CSS files still gets
the paths wrong.

On Nov 29, 2011, at 12:20 PM, "Chris M. Welsh"
reply@reply.github.com
wrote:

This is a very serious bug for those who use LESS extensively in the browser. Please push out a new minor version.

---

Reply to this email directly or view it on GitHub:
#478 (comment)