-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactorings of p2p
crate
#150
Merged
Merged
Commits on Oct 26, 2023
-
Instead of passing a mutable outbox to all sub-systems, have all sub-systems implement `Iterator`.
Configuration menu - View commit details
-
Copy full SHA for 3f57c32 - Browse repository at this point
Copy the full SHA 3f57c32View commit details -
Configuration menu - View commit details
-
Copy full SHA for 923e7e5 - Browse repository at this point
Copy the full SHA 923e7e5View commit details
Commits on Nov 5, 2023
-
Instead of having each manager module have its own events, we use a single event namespace. This simplifies the client event mapper, which can be removed in a subsequent commit.
Configuration menu - View commit details
-
Copy full SHA for b67221a - Browse repository at this point
Copy the full SHA b67221aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e7a1432 - Browse repository at this point
Copy the full SHA e7a1432View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b33954 - Browse repository at this point
Copy the full SHA 9b33954View commit details -
[p2p] Use
PeerNegotiated
event to refactorInstead of relying on the return value when receiving a `verack`, we rely on the `PeerNegotiated` event, internalizing more of the logic. In passing, we remove the `Socket` abstraction, which wasn't used.
Configuration menu - View commit details
-
Copy full SHA for 53f0807 - Browse repository at this point
Copy the full SHA 53f0807View commit details -
[p2p] Use event for propagating re-orgs
Further reduce logic inside `fsm.rs`.
Configuration menu - View commit details
-
Copy full SHA for 1e83edb - Browse repository at this point
Copy the full SHA 1e83edbView commit details -
[p2p] Capitalize event strings
Since these are used in logs, they should be consistent with the other logs.
Configuration menu - View commit details
-
Copy full SHA for 2a42724 - Browse repository at this point
Copy the full SHA 2a42724View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8747838 - Browse repository at this point
Copy the full SHA 8747838View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d84521 - Browse repository at this point
Copy the full SHA 1d84521View commit details -
Configuration menu - View commit details
-
Copy full SHA for e968f90 - Browse repository at this point
Copy the full SHA e968f90View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7e958f - Browse repository at this point
Copy the full SHA d7e958fView commit details
Commits on Nov 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 71cd341 - Browse repository at this point
Copy the full SHA 71cd341View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e111bd - Browse repository at this point
Copy the full SHA 2e111bdView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.