always use options.headers to set Server header #52

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@pbouzakis
Contributor

inside finish, instead of setting Server header to the serverInfo variable, set it to the options.header.Server value, which is set in the constructor function and defaults to the serverInfo variable.

on 404 errors, the server would always report node static as the server even if the client code passed in a different Server header in the options param.

@pbouzakis pbouzakis always use options.headers to set Server header
inside finish, instead of setting Server header to the serverInfo variable, set it to the options.header.Server value, which is set in the constructor function and defaults to the serverInfo variable.

on 404 errors, the server would always report node static as the server even if the client code passed in a different Server header in the options param.
09cb9b4
@phstc phstc closed this Oct 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment