-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] chaptersButton not working #469
Comments
# Description * Updates video player types to get fix for chapters button * Adds examples to docs for chapters ## Issue Ticket Number Fixes #469 <!-- Specify above which issue this fixes by referencing the issue number (`#<ISSUE_NUMBER>`) or issue URL. --> <!-- Example: Fixes https://github.com/cloudinary-community/next-cloudinary/issues/<ISSUE_NUMBER> --> ## Type of change <!-- Please select all options that are applicable. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Fix or improve the documentation - [ ] This change requires a documentation update # Checklist <!-- These must all be followed and checked. --> - [ ] I have followed the contributing guidelines of this project as mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md) - [ ] I have created an [issue](https://github.com/cloudinary-community/next-cloudinary/issues) ticket for this PR - [ ] I have checked to ensure there aren't other open [Pull Requests](https://github.com/cloudinary-community/next-cloudinary/pulls) for the same update/change? - [ ] I have performed a self-review of my own code - [ ] I have run tests locally to ensure they all pass - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes needed to the documentation
🎉 This issue has been resolved in version 6.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
hey @jmsherry apologies for the delay it looks like the parameter was moved out of controlBar into a top level option and the documentation needed to be updated to reflect that, which is now fixed ive updated the types to also reflect this in the latest version of Next Cloudinary as well as put an example in the documentation https://next.cloudinary.dev/cldvideoplayer/examples#chapters--selector |
That's awesome! Thank you Colby! :) |
Bug Report
Describe the bug
As described here in the cloudinary docs and then used in the
controlBar
prop you should be able to add a button that allows a user to select a chapter, like so:Before going further, I'd like to point out that it doesn't seem to be working on Cloudinary's docs page either!
Is this a regression?
No.
Steps To Reproduce the error
CldVideoPlayer
componentcontrolBar={{ chaptersButton: true, }}
)Expected behaviour
A button appears that allows a user to select a chapter
Your environment
The text was updated successfully, but these errors were encountered: