Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] chaptersButton not working #469

Closed
jmsherry opened this issue Apr 19, 2024 · 3 comments · Fixed by #473
Closed

[Bug] chaptersButton not working #469

jmsherry opened this issue Apr 19, 2024 · 3 comments · Fixed by #473
Labels

Comments

@jmsherry
Copy link

Bug Report

Describe the bug

As described here in the cloudinary docs and then used in the controlBar prop you should be able to add a button that allows a user to select a chapter, like so:

<CldVideoPlayer  controls aiHighlightsGraph showJumpControls playbackRates={[0.25, 0.5, 0.75, 1, 2, 3]} controlBar={{
    chaptersButton: true,
  }} {...props} />

Before going further, I'd like to point out that it doesn't seem to be working on Cloudinary's docs page either!

Is this a regression?

No.

Steps To Reproduce the error

  1. Use the CldVideoPlayer component
  2. Add the chaptersButton (controlBar={{ chaptersButton: true, }})
  3. (Make sure you have chapters added!)
  4. Observe how there is no button to allow chapter selection

Expected behaviour

A button appears that allows a user to select a chapter

Your environment

  • OS: macOS Sonoma 14.1.1
  • Node version: 20.11.1
  • Npm version: 10.2.4
  • Browser name and version: Chrome Version 123.0.6312.124 (Official Build) (x86_64)
@colbyfayock colbyfayock mentioned this issue May 6, 2024
12 tasks
colbyfayock added a commit that referenced this issue May 6, 2024
# Description

* Updates video player types to get fix for chapters button
* Adds examples to docs for chapters

## Issue Ticket Number

Fixes #469 

<!-- Specify above which issue this fixes by referencing the issue
number (`#<ISSUE_NUMBER>`) or issue URL. -->
<!-- Example: Fixes
https://github.com/cloudinary-community/next-cloudinary/issues/<ISSUE_NUMBER>
-->

## Type of change

<!-- Please select all options that are applicable. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Fix or improve the documentation
- [ ] This change requires a documentation update


# Checklist

<!-- These must all be followed and checked. -->

- [ ] I have followed the contributing guidelines of this project as
mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md)
- [ ] I have created an
[issue](https://github.com/cloudinary-community/next-cloudinary/issues)
ticket for this PR
- [ ] I have checked to ensure there aren't other open [Pull
Requests](https://github.com/cloudinary-community/next-cloudinary/pulls)
for the same update/change?
- [ ] I have performed a self-review of my own code
- [ ] I have run tests locally to ensure they all pass
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes needed to the documentation
github-actions bot pushed a commit that referenced this issue May 6, 2024
## [6.5.2](v6.5.1...v6.5.2) (2024-05-06)

### Bug Fixes

* ChaptersButton Types ([#473](#473)) ([10ba89c](10ba89c)), closes [#469](#469)
Copy link

github-actions bot commented May 6, 2024

🎉 This issue has been resolved in version 6.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@colbyfayock
Copy link
Collaborator

hey @jmsherry apologies for the delay

it looks like the parameter was moved out of controlBar into a top level option and the documentation needed to be updated to reflect that, which is now fixed

ive updated the types to also reflect this in the latest version of Next Cloudinary as well as put an example in the documentation

https://next.cloudinary.dev/cldvideoplayer/examples#chapters--selector

@jmsherry
Copy link
Author

jmsherry commented May 6, 2024

That's awesome! Thank you Colby! :)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants