Allow Rename and Tag update calls to specify a ResourceType #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed added manually. |
|
Thanks, I see that you've added it in for Rename, but the Tag call is still stuck on Images only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Rename()andTag()api calls were locked toResourceType.Image(since they were usingApiUrlImgUpV).I've added a new
ResourceTypeparameter to their respective Params classes (used same code as is already used inDeletionParams), defaulted toResourceType.Imagefor backwards compatibility.The
ResourceTypeparameter is then used when creating the API call for Rename/Tag action.Hope I've submitted this correctly - I've been using Git for a while, but this is my first attempt at a pull request :)