Skip to content

Commit

Permalink
Add support for the fps parameter
Browse files Browse the repository at this point in the history
  • Loading branch information
Amir Tocker committed Dec 6, 2018
1 parent 65321a7 commit 3ee62e4
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 0 deletions.
5 changes: 5 additions & 0 deletions lib/cloudinary/utils.rb
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ class Cloudinary::Utils
end_offset
fetch_format
flags
fps
gravity
height
if
Expand Down Expand Up @@ -190,6 +191,9 @@ def self.generate_transformation_string(options={}, allow_implicit_crop_mode = f
options[:start_offset], options[:end_offset] = split_range options.delete(:offset)
end

fps = options.delete(:fps)
fps = fps.join('-') if fps.is_a? Array

overlay = process_layer(options.delete(:overlay))
underlay = process_layer(options.delete(:underlay))
ifValue = process_if(options.delete(:if))
Expand All @@ -207,6 +211,7 @@ def self.generate_transformation_string(options={}, allow_implicit_crop_mode = f
:e => normalize_expression(effect),
:fl => flags,
:fn => custom_function || custom_pre_function,
:fps => fps,
:h => normalize_expression(height),
:l => overlay,
:o => normalize_expression(options.delete(:opacity)),
Expand Down
14 changes: 14 additions & 0 deletions spec/video_url_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,20 @@

end
end
it "should support the fps parameter" do
[
['24-29.97', 'fps_24-29.97'],
[24, 'fps_24'],
[24.973, 'fps_24.973'],
['24', 'fps_24'],
['-24', 'fps_-24'],
['$v', 'fps_$v'],
[[24, 29.97], 'fps_24-29.97'],
[['24', '$v'], 'fps_24-$v']
].each do |value, param|
expect(Cloudinary::Utils.generate_transformation_string(:fps => value)).to eq(param)
end
end
end

end

0 comments on commit 3ee62e4

Please sign in to comment.