This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
feat: bump WDIO version to 8 #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: bumping new WDIO version to 8
rashelle-cld
approved these changes
Aug 8, 2023
|
:) |
rashelle-cld
reviewed
Aug 8, 2023
| process.env.TEST_DATA_TAG = 'test-user'; | ||
| await Reporter.step('getData reads from file'); | ||
| const data: ITestData = await TestUtils.getData(); | ||
| assert.equal(data.fileName, 'example'); | ||
| }); | ||
|
|
||
| it('Check incorrect user', async () => { | ||
| it.skip('Check incorrect user', async () => { | ||
| process.env.TEST_DATA_TAG = 'incorrect-user'; | ||
| await Reporter.step('undefined returned in case of incorrect data tag'); | ||
| const data: ITestData = await TestUtils.getData(); |
There was a problem hiding this comment.
since wdio.conf is typed now, we can't add things like
configDataFilePath: 'src/test/resources/example.json',
Since I didn't find any usage of it, I skipped the tests. Probably better to remove them
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: bumping new WDIO version to 8
Brief Summary of Changes
Reviewer, Please Note:
Testing (what was tested)