Nil check objects before putting inside an array within CMStore #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was seeing sporadic linker errors after upgrading to CocoaPods 1.0.1. A more aggressive refactoring of the Podfile to conform to the 1.0+ syntax seems to have resolved the issues.
…: it should be a no-op that does not crash but currently throws an exception, per cloudmine#72
| @@ -631,13 +631,21 @@ - (void)saveUserObject:(CMObject *)theObject additionalOptions:(CMStoreOptions * | |||
| } | |||
| return; | |||
| } | |||
|
|
|||
| if (nil == theObject) { | |||
| return; | |||
There was a problem hiding this comment.
What do you think about logging a debug message in this case? Often a nil object is indicative of a CM response that was unexpected (perhaps a malformed search query, etc).
|
@marcweil good idea; updated to add a log message in each case |
|
Perfect. Looks good to me then! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to save a nil object or acl is now an (effective) no-op, instead of causing the app to crash.