Add config value endpointCA for private S3 such as MinIO #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PseudoResonance <kaio11604@gmail.com>
|
I am aware of this. I already have a solution for it as part of my work on a KUTTL test suite here, where I needed to add That being said, your solution seems to be better. |
itay-grudev
requested changes
Mar 26, 2024
Signed-off-by: PseudoResonance <kaio11604@gmail.com>
itay-grudev
approved these changes
Mar 26, 2024
itay-grudev
added a commit
that referenced
this pull request
Mar 27, 2024
* Added the ability to exclude specific PrometheusRules by @itay-grudev (#232) * Added config value endpointCA for private S3 such as MinIO by @PseudoResonance (#229, #230) * Bug Fix: Severity of CNPGClusterLowDiskSpaceCritical should be critical not warning by @baurmatt (#223) * New `backup.barmanObjectStore.wal` and `backup.barmanObjectStore.data` to support disabling encryption by @itay-grudev (#198, #221) Signed-off-by: Itay Grudev <itay.grudev@essentim.com>
Merged
itay-grudev
added a commit
that referenced
this pull request
Mar 27, 2024
* Added the ability to exclude specific PrometheusRules by @itay-grudev (#232) * Added config value endpointCA for private S3 such as MinIO by @PseudoResonance (#229, #230) * Bug Fix: Severity of CNPGClusterLowDiskSpaceCritical should be critical not warning by @baurmatt (#223) * New `backup.barmanObjectStore.wal` and `backup.barmanObjectStore.data` to support disabling encryption by @itay-grudev (#198, #221) Signed-off-by: Itay Grudev <itay.grudev@essentim.com> Co-authored-by: Itay Grudev <itay.grudev@essentim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a chart values to
endpointCAin both the backup and recovery sections, allowing a user to specify a private CA. The value is stored in a secret, which can either be created manually, or will be created automatically if thecreateoption is true.Resolves #229