Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to exclude specific PrometheusRules #232

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

itay-grudev
Copy link
Collaborator

@itay-grudev itay-grudev commented Mar 26, 2024

Adds the ability to disable specific PrometheusRules:

cluster:
  monitoring:
    prometheusRule:
      excludeRules: # NEW
        - CNPGClusterHAWarning
        - CNPGClusterZoneSpreadWarning

In the process I also restructured how Prometheus rules are generated so each one now has its own file.

Signed-off-by: Itay Grudev <itay.grudev@essentim.com>
Signed-off-by: Itay Grudev <itay.grudev@essentim.com>
@itay-grudev itay-grudev self-assigned this Mar 26, 2024
@itay-grudev itay-grudev requested a review from phisco March 26, 2024 18:10
@itay-grudev itay-grudev requested a review from phisco March 26, 2024 20:41
@itay-grudev itay-grudev merged commit 7412346 into main Mar 26, 2024
5 checks passed
@itay-grudev itay-grudev deleted the disable_prometheus_rules branch March 26, 2024 21:01
itay-grudev added a commit that referenced this pull request Mar 27, 2024
* Added the ability to exclude specific PrometheusRules by @itay-grudev (#232)
* Added config value endpointCA for private S3 such as MinIO by @PseudoResonance (#229, #230)
* Bug Fix: Severity of CNPGClusterLowDiskSpaceCritical should be critical not warning by @baurmatt (#223)
* New `backup.barmanObjectStore.wal` and `backup.barmanObjectStore.data` to support disabling encryption by @itay-grudev (#198, #221)

Signed-off-by: Itay Grudev <itay.grudev@essentim.com>
itay-grudev added a commit that referenced this pull request Mar 27, 2024
* Added the ability to exclude specific PrometheusRules by @itay-grudev (#232)
* Added config value endpointCA for private S3 such as MinIO by @PseudoResonance (#229, #230)
* Bug Fix: Severity of CNPGClusterLowDiskSpaceCritical should be critical not warning by @baurmatt (#223)
* New `backup.barmanObjectStore.wal` and `backup.barmanObjectStore.data` to support disabling encryption by @itay-grudev (#198, #221)

Signed-off-by: Itay Grudev <itay.grudev@essentim.com>
Co-authored-by: Itay Grudev <itay.grudev@essentim.com>
@itay-grudev itay-grudev added the chart( cluster ) Related to the cluster chart label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart( cluster ) Related to the cluster chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants